From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] ext4: missing trace_ext4_ext_map_blocks_exit after calling ext4_ext_handle_uninitialized_extents
Date: Thu, 8 Nov 2012 14:50:06 -0500 [thread overview]
Message-ID: <20121108195006.GJ19977@thunk.org> (raw)
In-Reply-To: <1350372696-18013-1-git-send-email-wenqing.lz@taobao.com>
On Tue, Oct 16, 2012 at 03:31:36PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> When ext4_ext_handle_uninitialized_extents is called, we will directly return
> from ext4_ext_map_blocks. The trace point of trace_ext4_ext_map_blocks_exit
> isn't called, and the user doesn't see any result. This patch tries to fix this
> problem.
>
> Meanwhile in ext4_ext_handle_uninitialized_extents it returns errors or the
> number of allocated blocks. So 'ret' variable can be removed due to previously
> modifications.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2012-11-08 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 7:31 [PATCH] ext4: missing trace_ext4_ext_map_blocks_exit after calling ext4_ext_handle_uninitialized_extents Zheng Liu
2012-11-08 19:50 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108195006.GJ19977@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).