From: Theodore Ts'o <tytso@mit.edu>
To: Zach Brown <zab@zabbo.net>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 3/6 -v3] libext2fs: add ext2fs_bitcount() function
Date: Tue, 27 Nov 2012 14:37:49 -0500 [thread overview]
Message-ID: <20121127193749.GA19085@thunk.org> (raw)
In-Reply-To: <20121127175023.GI23854@lenny.home.zabbo.net>
On Tue, Nov 27, 2012 at 09:50:23AM -0800, Zach Brown wrote:
>
> Agreed. I'll chuck it at the end of my fun-projects-some-day list as
> well, but getting it right for all the platforms that e2fsprogs
> supports.. meh :).
It's not strictly necessary to get things right for all platforms; we
already have some accelerations using asm statements which only work
for one platform already --- although it's already the case that I
didn't bother to make 64-bit set/clear/test bit optimizations for x86,
mainly because I didn't think it was worth it, especially on modern
CPU's. (And with the red/black tree backend for bitmaps, the asm
bitops are even less important.)
- Ted
next prev parent reply other threads:[~2012-11-27 19:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 16:39 [PATCH 0/6 -v2] Optimize e2fsck for large file systems Theodore Ts'o
2012-11-26 16:39 ` [PATCH 1/6 -v2] libext2fs: optimize rb_set_bmap_range() Theodore Ts'o
2012-11-27 7:16 ` Lukáš Czerner
2012-11-26 16:39 ` [PATCH 2/6 -v2] e2fsck: optimize pass1 for CPU time Theodore Ts'o
2012-11-26 16:39 ` [PATCH 3/6 -v3] libext2fs: add ext2fs_bitcount() function Theodore Ts'o
2012-11-26 23:17 ` Zach Brown
2012-11-27 1:45 ` Theodore Ts'o
2012-11-27 5:16 ` Theodore Ts'o
2012-11-27 17:50 ` Zach Brown
2012-11-27 19:37 ` Theodore Ts'o [this message]
2012-11-27 17:54 ` Zach Brown
2012-11-26 16:39 ` [PATCH 4/6 -v2] libext2fs: optimize rb_get_bmap_range() Theodore Ts'o
2012-11-26 16:39 ` [PATCH 5/6 -v2] libext2fs: optimize rb_get_bmap_range() for mostly allocated bmaps Theodore Ts'o
2012-11-26 16:39 ` [PATCH 6/6 -v2] e2fsck: optimize pass 5 for CPU utilization Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121127193749.GA19085@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).