From: Fengguang Wu <fengguang.wu@intel.com>
To: Tao Ma <tm@tao.ma>
Cc: Tao Ma <boyu.mt@taobao.com>,
linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [ext4:dev 56/60] fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers
Date: Mon, 3 Dec 2012 14:18:36 +0800 [thread overview]
Message-ID: <20121203061836.GA12998@localhost> (raw)
In-Reply-To: <50BC3AB0.1060708@tao.ma>
Tao,
Perhaps you can create an incremental fix, which allows Ted to easily
check how it's fixed, and have the freedom to either fold it to the
bad commit, or to append to HEAD.
Thanks,
Fengguang
On Mon, Dec 03, 2012 at 01:37:52PM +0800, Tao Ma wrote:
> Great thanks, Fengguang.
>
> So Ted,
> do you want me to send a new patch set? Or you just want me to generate
> a patch for all these warnings Fengguang found?
>
> Thanks
> Tao
>
>
> On 12/03/2012 01:12 PM, kbuild test robot wrote:
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
> > head: e9f49e454264c1cdd793552bfeb44f337508201b
> > commit: a7b0168d4a9bb78535827ddaf9c055963f5bd7aa [56/60] ext4: let fallocate handle inline data correctly
> > config: i386-randconfig-m085 (attached as .config)
> >
> > All error/warnings:
> >
> > In file included from fs/ext4/dir.c:30:0:
> > fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers
> > fs/ext4/xattr.h:422:16: warning: 'ext4_convert_inline_data' defined but not used [-Wunused-function]
> > --
> > In file included from fs/ext4/extents.c:45:0:
> > fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers
> >
> > vim +422 fs/ext4/xattr.h
> >
> > 18dfee69 Tao Ma 2012-12-02 416 static inline void ext4_inline_data_truncate(struct inode *inode,
> > 18dfee69 Tao Ma 2012-12-02 417 int *has_inline)
> > 18dfee69 Tao Ma 2012-12-02 418 {
> > 18dfee69 Tao Ma 2012-12-02 419 return;
> > 18dfee69 Tao Ma 2012-12-02 420 }
> > 18dfee69 Tao Ma 2012-12-02 421
> > a7b0168d Tao Ma 2012-12-02 @422 static int int ext4_convert_inline_data(struct inode *inode)
> > a7b0168d Tao Ma 2012-12-02 423 {
> > a7b0168d Tao Ma 2012-12-02 424 return 0;
> > a7b0168d Tao Ma 2012-12-02 425 }
> >
> > ---
> > 0-DAY kernel build testing backend Open Source Technology Center
> > Fengguang Wu, Yuanhan Liu Intel Corporation
> >
next prev parent reply other threads:[~2012-12-03 6:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 5:12 [ext4:dev 56/60] fs/ext4/xattr.h:422:12: error: two or more data types in declaration specifiers kbuild test robot
2012-12-03 5:37 ` Tao Ma
2012-12-03 6:18 ` Fengguang Wu [this message]
2012-12-03 8:30 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203061836.GA12998@localhost \
--to=fengguang.wu@intel.com \
--cc=boyu.mt@taobao.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox