* [patch] ext4: unneeded variable in ext4_try_add_inline_entry()
@ 2012-12-05 8:08 Dan Carpenter
2012-12-06 17:23 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-12-05 8:08 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Andreas Dilger, linux-ext4, kernel-janitors
We never actually use "backup_buf" so I have removed it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 1fe0cc4..26e4218 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1224,7 +1224,7 @@ int ext4_try_add_inline_entry(handle_t *handle, struct dentry *dentry,
struct inode *inode)
{
int ret, inline_size;
- void *inline_start, *backup_buf = NULL;
+ void *inline_start;
struct ext4_iloc iloc;
struct inode *dir = dentry->d_parent->d_inode;
@@ -1276,7 +1276,6 @@ int ext4_try_add_inline_entry(handle_t *handle, struct dentry *dentry,
ret = ext4_convert_inline_data_nolock(handle, dir, &iloc);
out:
- kfree(backup_buf);
ext4_mark_inode_dirty(handle, dir);
up_write(&EXT4_I(dir)->xattr_sem);
brelse(iloc.bh);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ext4: unneeded variable in ext4_try_add_inline_entry()
2012-12-05 8:08 [patch] ext4: unneeded variable in ext4_try_add_inline_entry() Dan Carpenter
@ 2012-12-06 17:23 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2012-12-06 17:23 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Andreas Dilger, linux-ext4, kernel-janitors, Tao Ma
On Wed, Dec 05, 2012 at 11:08:37AM +0300, Dan Carpenter wrote:
> We never actually use "backup_buf" so I have removed it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
I've merged this into the inline data patches; thanks for reporting it!
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-06 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 8:08 [patch] ext4: unneeded variable in ext4_try_add_inline_entry() Dan Carpenter
2012-12-06 17:23 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).