From: Theodore Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org, David Brown <davidb@codeaurora.org>,
Jan Kara <jack@suse.cz>, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] ext4: Remove CONFIG_EXT4_FS_XATTR.
Date: Mon, 10 Dec 2012 14:21:39 -0500 [thread overview]
Message-ID: <20121210192139.GE7516@thunk.org> (raw)
In-Reply-To: <1355120348-5117-1-git-send-email-tm@tao.ma>
Applied, with some minor fixups so it works with the extents_status
tree patches, and also to fix a buglet which in fs/ext4/super.c:
> @@ -1447,13 +1445,10 @@ static const struct mount_opts {
> {Opt_data_journal, EXT4_MOUNT_JOURNAL_DATA, MOPT_DATAJ},
> {Opt_data_ordered, EXT4_MOUNT_ORDERED_DATA, MOPT_DATAJ},
> {Opt_data_writeback, EXT4_MOUNT_WRITEBACK_DATA, MOPT_DATAJ},
> -#ifdef CONFIG_EXT4_FS_XATTR
> {Opt_user_xattr, EXT4_MOUNT_XATTR_USER, MOPT_SET},
> {Opt_nouser_xattr, EXT4_MOUNT_XATTR_USER, MOPT_CLEAR},
> -#else
> {Opt_user_xattr, 0, MOPT_NOSUPPORT},
> {Opt_nouser_xattr, 0, MOPT_NOSUPPORT},
> -#endif
The table entries between the #else and #endif in the above patch
chunlk needs to be removed as well.
I've fixed this in my tree.
Regards,
- Ted
prev parent reply other threads:[~2012-12-10 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 22:35 RFC: remove CONFIG_EXT4_FS_XATTR Theodore Ts'o
2012-12-05 23:04 ` Eric Sandeen
2012-12-06 1:33 ` Tao Ma
2012-12-06 3:48 ` Theodore Ts'o
2012-12-06 19:28 ` David Brown
2012-12-06 10:26 ` Jan Kara
2012-12-10 6:19 ` [PATCH] ext4: Remove CONFIG_EXT4_FS_XATTR Tao Ma
2012-12-10 10:08 ` Jan Kara
2012-12-10 15:11 ` [PATCH V2] " Tao Ma
2012-12-10 19:21 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210192139.GE7516@thunk.org \
--to=tytso@mit.edu \
--cc=davidb@codeaurora.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).