From: Theodore Ts'o <tytso@mit.edu>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Tao Ma <boyu.mt@taobao.com>, linux-ext4@vger.kernel.org
Subject: Re: [ext4:dev 62/63] ERROR: "mb_cache_entry_find_next" [fs/ext4/ext4.ko] undefined!
Date: Mon, 10 Dec 2012 16:27:50 -0500 [thread overview]
Message-ID: <20121210212750.GA12851@thunk.org> (raw)
In-Reply-To: <50c64786.6SgYYMd9siG5ynlG%fengguang.wu@intel.com>
We forgot to audit remote dependencies outside of the fs/ext4 tree on
CONFIG_EXT4_FS_XATTR. The following patch should fix things up. (I
won't bother editing all of the defconfig files, since the extra
CONFIG option doesn't do any harm, and modifying those files increases
the chances of merge conflicts.)
Thanks, kbuild test robot! :-)
- Ted
diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
index 104322b..34ea4f1 100644
--- a/Documentation/filesystems/ext4.txt
+++ b/Documentation/filesystems/ext4.txt
@@ -200,12 +200,9 @@ inode_readahead_blks=n This tuning parameter controls the maximum
table readahead algorithm will pre-read into
the buffer cache. The default value is 32 blocks.
-nouser_xattr Disables Extended User Attributes. If you have extended
- attribute support enabled in the kernel configuration
- (CONFIG_EXT4_FS_XATTR), extended attribute support
- is enabled by default on mount. See the attr(5) manual
- page and http://acl.bestbits.at/ for more information
- about extended attributes.
+nouser_xattr Disables Extended User Attributes. See the
+ attr(5) manual page and http://acl.bestbits.at/
+ for more information about extended attributes.
noacl This option disables POSIX Access Control List
support. If ACL support is enabled in the kernel
diff --git a/fs/Kconfig b/fs/Kconfig
index f95ae3a..eaff24a 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -28,8 +28,8 @@ config FS_MBCACHE
tristate
default y if EXT2_FS=y && EXT2_FS_XATTR
default y if EXT3_FS=y && EXT3_FS_XATTR
- default y if EXT4_FS=y && EXT4_FS_XATTR
- default m if EXT2_FS_XATTR || EXT3_FS_XATTR || EXT4_FS_XATTR
+ default y if EXT4_FS=y
+ default m if EXT2_FS_XATTR || EXT3_FS_XATTR || EXT4_FS
source "fs/reiserfs/Kconfig"
source "fs/jfs/Kconfig"
prev parent reply other threads:[~2012-12-10 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 20:35 [ext4:dev 62/63] ERROR: "mb_cache_entry_find_next" [fs/ext4/ext4.ko] undefined! kbuild test robot
2012-12-10 21:27 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210212750.GA12851@thunk.org \
--to=tytso@mit.edu \
--cc=boyu.mt@taobao.com \
--cc=fengguang.wu@intel.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).