linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-ext4@vger.kernel.org
Subject: [Bug 51571] Assertion of j_running_transaction on jbd2_journal_flush()
Date: Wed, 12 Dec 2012 00:01:04 +0000 (UTC)	[thread overview]
Message-ID: <20121212000104.75D4D11F993@bugzilla.kernel.org> (raw)
In-Reply-To: <bug-51571-13602@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=51571


Jan Kara <jack@suse.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jack@suse.cz




--- Comment #1 from Jan Kara <jack@suse.cz>  2012-12-12 00:01:04 ---
Thanks for detailed report! I presume you have a crash dump when you could
provide such details? Can you have a look at what
journal->j_running_transaction->t_handle_count is? I can see the transaction
has been started some 14 ms ago. That's not too long but still plenty in terms
of CPU time.

What I think is happening is:
Process A                                    Process B
start_this_handle().
  if (journal->j_barrier_count) # false
  if (!journal->j_running_transaction) { #true
    read_unlock(&journal->j_state_lock);
                                           jbd2_journal_lock_updates()
                                           jbd2_journal_flush()
                                            
write_lock(&journal->j_state_lock);
                                             if
(journal->j_running_transaction) {
                                               #false
                                             ... wait for committing trans ...
                                            
write_unlock(&journal->j_state_lock);
    ...
    write_lock(&journal->j_state_lock);
    jbd2_get_transaction(journal, new_transaction); # Sets
j_running_transaction
    write_unlock(&journal->j_state_lock);
    goto repeat; # eventually blocks on j_barrier_count > 0

I will attach here a patch that should fix this...

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

  reply	other threads:[~2012-12-12  0:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11  9:26 [Bug 51571] New: Assertion of j_running_transaction on jbd2_journal_flush() bugzilla-daemon
2012-12-12  0:01 ` bugzilla-daemon [this message]
2012-12-12  0:10 ` [Bug 51571] " bugzilla-daemon
2012-12-12  4:26 ` bugzilla-daemon
2012-12-12 15:18 ` bugzilla-daemon
2012-12-12 15:18 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121212000104.75D4D11F993@bugzilla.kernel.org \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).