From: Theodore Ts'o <tytso@mit.edu>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-ext4@vger.kernel.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH] e2fsprogs: m68k bitops fixes
Date: Mon, 17 Dec 2012 09:49:02 -0500 [thread overview]
Message-ID: <20121217144902.GC31563@thunk.org> (raw)
In-Reply-To: <20686.16276.932405.296864@pilspetsen.it.uu.se>
On Sun, Dec 16, 2012 at 10:39:32PM +0100, Mikael Pettersson wrote:
> Andreas Schwab suggested that there was no longer an advantage
> to using inline asm for these operations, so this new patch
> deletes the m68k-specific code from lib/ext2fs/bitops.h (leaving
> only 32-bit x86 to still use inline asm there).
Yep, agreed. Thanks for the patch! I've applied it in the e2fsprogs
maint branch.
It would be a good idea to check the m68k kernel, since it was cribbed
from the kernel sources. I do agree though that it's unlikely to be a
problem in kernel code.
Thanks again!!
- Ted
next prev parent reply other threads:[~2012-12-17 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 13:40 [PATCH] e2fsprogs: m68k bitops fixes Mikael Pettersson
2012-12-16 21:39 ` Mikael Pettersson
2012-12-17 14:49 ` Theodore Ts'o [this message]
2012-12-17 18:15 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217144902.GC31563@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).