From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Anders Lind <anderslindgaard@yahoo.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: Tune2fs metadata_csum
Date: Mon, 17 Dec 2012 19:19:23 -0800 [thread overview]
Message-ID: <20121218031923.GA10770@blackbox.djwong.org> (raw)
In-Reply-To: <20121217143703.GB31563@thunk.org>
On Mon, Dec 17, 2012 at 09:37:03AM -0500, Theodore Ts'o wrote:
> On Sun, Dec 16, 2012 at 08:04:01PM -0800, Anders Lind wrote:
> >
> > I tired to use tune2fs metadata_csum feature on my ext4 filesystem.
> > I got message like:
> > ~$ sudo tune2fs -O metadata_csum /dev/sda5
> > tune2fs 1.42 (29-Nov-2011)
> > Setting filesystem feature 'metadata_csum' not supported.
> >
> > Is this tool supposed been used on unmounted device or it could be mounted?
>
> TYhe metadata_csum feature is in the e2fsprogs "master" branch in the
> e2fsprogs git tree. The feature is not part of an official e2fsprogs
> release yet. One of the things that I want to really check very
> carefully before I release e2fsprogs 1.43 is that e2fsck sanely
> recovers from checksum failures while it tries replaying the journal.
Oh, right, I /was/ planning (last year) to go dig through recovery.c, wasn't I?
And I think I was going to change the replay/checksum behavior so that checksum
errors would result in that block being skipped, without aborting the entire
replay.
(Or something like that? My memory is hazy.)
Well, thanks for the reminder.
--D
>
> Essentially, metadata_csum is supposed to provide better recovery from
> device failures (it doesn't really provide any kind of performance
> advantage), and I want to be 100% sure that it is **always** better
> when hardware-induced corruption happens before we release it.
>
> Regards,
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-12-18 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 4:04 Tune2fs metadata_csum Anders Lind
2012-12-17 7:23 ` Zheng Liu
2012-12-17 14:37 ` Theodore Ts'o
2012-12-18 3:19 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218031923.GA10770@blackbox.djwong.org \
--to=darrick.wong@oracle.com \
--cc=anderslindgaard@yahoo.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).