* [RFC PATCH] ext3, ext4, ocfs2: remove unused macro NAMEI_RA_INDEX
@ 2012-12-18 8:56 Guo Chao
2012-12-18 17:48 ` Jan Kara
0 siblings, 1 reply; 4+ messages in thread
From: Guo Chao @ 2012-12-18 8:56 UTC (permalink / raw)
To: akpm; +Cc: Jan Kara, Theodore Ts'o, Mark Fasheh, linux-ext4, ocfs2-devel
This macro, initially introduced by ext2 in v0.99.15, does not
have any users from the beginning. It has been removed in later
ext2 version but still remains in the code of ext3, ext4, ocfs2.
Remove this macro there.
Cc: Jan Kara <jack@suse.cz>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: linux-ext4@vger.kernel.org
Cc: ocfs2-devel@oss.oracle.com
Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
---
fs/ext3/namei.c | 1 -
fs/ext4/namei.c | 1 -
fs/ocfs2/dir.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
index 890b894..88f64eb 100644
--- a/fs/ext3/namei.c
+++ b/fs/ext3/namei.c
@@ -36,7 +36,6 @@
#define NAMEI_RA_CHUNKS 2
#define NAMEI_RA_BLOCKS 4
#define NAMEI_RA_SIZE (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
-#define NAMEI_RA_INDEX(c,b) (((c) * NAMEI_RA_BLOCKS) + (b))
static struct buffer_head *ext3_append(handle_t *handle,
struct inode *inode,
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index cac4482..3f8c3d4 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -47,7 +47,6 @@
#define NAMEI_RA_CHUNKS 2
#define NAMEI_RA_BLOCKS 4
#define NAMEI_RA_SIZE (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
-#define NAMEI_RA_INDEX(c,b) (((c) * NAMEI_RA_BLOCKS) + (b))
static struct buffer_head *ext4_append(handle_t *handle,
struct inode *inode,
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
index 8fe4e28..fc12135 100644
--- a/fs/ocfs2/dir.c
+++ b/fs/ocfs2/dir.c
@@ -67,7 +67,6 @@
#define NAMEI_RA_CHUNKS 2
#define NAMEI_RA_BLOCKS 4
#define NAMEI_RA_SIZE (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
-#define NAMEI_RA_INDEX(c,b) (((c) * NAMEI_RA_BLOCKS) + (b))
static unsigned char ocfs2_filetype_table[] = {
DT_UNKNOWN, DT_REG, DT_DIR, DT_CHR, DT_BLK, DT_FIFO, DT_SOCK, DT_LNK
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] ext3, ext4, ocfs2: remove unused macro NAMEI_RA_INDEX
2012-12-18 8:56 [RFC PATCH] ext3, ext4, ocfs2: remove unused macro NAMEI_RA_INDEX Guo Chao
@ 2012-12-18 17:48 ` Jan Kara
2012-12-18 20:51 ` Theodore Ts'o
2012-12-18 23:26 ` [Ocfs2-devel] " Mark Fasheh
0 siblings, 2 replies; 4+ messages in thread
From: Jan Kara @ 2012-12-18 17:48 UTC (permalink / raw)
To: Guo Chao
Cc: akpm, Jan Kara, Theodore Ts'o, Mark Fasheh, linux-ext4,
ocfs2-devel
On Tue 18-12-12 16:56:39, Guo Chao wrote:
> This macro, initially introduced by ext2 in v0.99.15, does not
> have any users from the beginning. It has been removed in later
> ext2 version but still remains in the code of ext3, ext4, ocfs2.
> Remove this macro there.
Thanks. I've merged the patch into my tree. Since it's trivial, I guess
other fs maintainers won't mind.
Honza
>
> Cc: Jan Kara <jack@suse.cz>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Mark Fasheh <mfasheh@suse.com>
> Cc: linux-ext4@vger.kernel.org
> Cc: ocfs2-devel@oss.oracle.com
> Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
> ---
> fs/ext3/namei.c | 1 -
> fs/ext4/namei.c | 1 -
> fs/ocfs2/dir.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index 890b894..88f64eb 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -36,7 +36,6 @@
> #define NAMEI_RA_CHUNKS 2
> #define NAMEI_RA_BLOCKS 4
> #define NAMEI_RA_SIZE (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b) (((c) * NAMEI_RA_BLOCKS) + (b))
>
> static struct buffer_head *ext3_append(handle_t *handle,
> struct inode *inode,
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index cac4482..3f8c3d4 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -47,7 +47,6 @@
> #define NAMEI_RA_CHUNKS 2
> #define NAMEI_RA_BLOCKS 4
> #define NAMEI_RA_SIZE (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b) (((c) * NAMEI_RA_BLOCKS) + (b))
>
> static struct buffer_head *ext4_append(handle_t *handle,
> struct inode *inode,
> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
> index 8fe4e28..fc12135 100644
> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -67,7 +67,6 @@
> #define NAMEI_RA_CHUNKS 2
> #define NAMEI_RA_BLOCKS 4
> #define NAMEI_RA_SIZE (NAMEI_RA_CHUNKS * NAMEI_RA_BLOCKS)
> -#define NAMEI_RA_INDEX(c,b) (((c) * NAMEI_RA_BLOCKS) + (b))
>
> static unsigned char ocfs2_filetype_table[] = {
> DT_UNKNOWN, DT_REG, DT_DIR, DT_CHR, DT_BLK, DT_FIFO, DT_SOCK, DT_LNK
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] ext3, ext4, ocfs2: remove unused macro NAMEI_RA_INDEX
2012-12-18 17:48 ` Jan Kara
@ 2012-12-18 20:51 ` Theodore Ts'o
2012-12-18 23:26 ` [Ocfs2-devel] " Mark Fasheh
1 sibling, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2012-12-18 20:51 UTC (permalink / raw)
To: Jan Kara; +Cc: Mark Fasheh, akpm, linux-ext4, Guo Chao, ocfs2-devel
On Tue, Dec 18, 2012 at 06:48:11PM +0100, Jan Kara wrote:
> On Tue 18-12-12 16:56:39, Guo Chao wrote:
> > This macro, initially introduced by ext2 in v0.99.15, does not
> > have any users from the beginning. It has been removed in later
> > ext2 version but still remains in the code of ext3, ext4, ocfs2.
> > Remove this macro there.
> Thanks. I've merged the patch into my tree. Since it's trivial, I guess
> other fs maintainers won't mind.
Acked-by: "Theodore Ts'o" <tytso@mit.edu>
Thanks, Jan!
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Ocfs2-devel] [RFC PATCH] ext3, ext4, ocfs2: remove unused macro NAMEI_RA_INDEX
2012-12-18 17:48 ` Jan Kara
2012-12-18 20:51 ` Theodore Ts'o
@ 2012-12-18 23:26 ` Mark Fasheh
1 sibling, 0 replies; 4+ messages in thread
From: Mark Fasheh @ 2012-12-18 23:26 UTC (permalink / raw)
To: Jan Kara; +Cc: Guo Chao, Theodore Ts'o, akpm, linux-ext4, ocfs2-devel
On Tue, Dec 18, 2012 at 06:48:11PM +0100, Jan Kara wrote:
> On Tue 18-12-12 16:56:39, Guo Chao wrote:
> > This macro, initially introduced by ext2 in v0.99.15, does not
> > have any users from the beginning. It has been removed in later
> > ext2 version but still remains in the code of ext3, ext4, ocfs2.
> > Remove this macro there.
> Thanks. I've merged the patch into my tree. Since it's trivial, I guess
> other fs maintainers won't mind.
Looks good, thanks!
Acked-by: Mark Fasheh <mfasheh@suse.de>
--Mark
--
Mark Fasheh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-18 23:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-18 8:56 [RFC PATCH] ext3, ext4, ocfs2: remove unused macro NAMEI_RA_INDEX Guo Chao
2012-12-18 17:48 ` Jan Kara
2012-12-18 20:51 ` Theodore Ts'o
2012-12-18 23:26 ` [Ocfs2-devel] " Mark Fasheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).