* [PATCH] ext4: Fix an incorrect comment about i_mutex
@ 2012-12-21 19:24 Andy Lutomirski
2012-12-25 18:30 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Andy Lutomirski @ 2012-12-21 19:24 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Jan Kara, linux-kernel, linux-ext4, Andy Lutomirski
i_mutex is not held when ->sync_file is called.
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
fs/ext4/fsync.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index be1d89f..8c15642 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -113,8 +113,6 @@ static int __sync_inode(struct inode *inode, int datasync)
*
* What we do is just kick off a commit and wait on it. This will snapshot the
* inode to disk.
- *
- * i_mutex lock is held when entering and exiting this function
*/
int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: Fix an incorrect comment about i_mutex
2012-12-21 19:24 [PATCH] ext4: Fix an incorrect comment about i_mutex Andy Lutomirski
@ 2012-12-25 18:30 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2012-12-25 18:30 UTC (permalink / raw)
To: Andy Lutomirski; +Cc: Jan Kara, linux-kernel, linux-ext4
On Fri, Dec 21, 2012 at 11:24:58AM -0800, Andy Lutomirski wrote:
> i_mutex is not held when ->sync_file is called.
>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-25 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-21 19:24 [PATCH] ext4: Fix an incorrect comment about i_mutex Andy Lutomirski
2012-12-25 18:30 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).