From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Alexander Beregalov <a.beregalov@gmail.com>,
"Theodore Ts'o\"" <tytso@mit.edu>,
linux-ext4@vger.kernel.org
Subject: Re: 3.8.0-rc1: WARNING: at fs/ext4/page-io.c:232
Date: Thu, 27 Dec 2012 18:33:42 +0800 [thread overview]
Message-ID: <20121227103342.GA4158@gmail.com> (raw)
In-Reply-To: <87mwwzq5t7.fsf@openvz.org>
On Thu, Dec 27, 2012 at 12:04:36PM +0400, Dmitry Monakhov wrote:
> On Thu, 27 Dec 2012 14:29:07 +0800, Zheng Liu <gnehzuil.liu@gmail.com> wrote:
> > On Thu, Dec 27, 2012 at 03:27:04AM +0300, Alexander Beregalov wrote:
[cut...]
> > Now we try to take i_mutex lock before orphan list cleanup, although we don't
> > need to take it in ext4_orphan_cleanup() because no one write this inode.
> > WARN_ON_ONCE doesn't be removed because this warning could help us to avoid some
> > ciritcal errors.
> You can add Ack-by: Dmitry Monakhov <dmonakhov@openvz.org>
>
> In fact this is my fault that we still not have autotest for that.
> I'm think of add crash-test to xfstests which should trigger journal abort and forced
> umount. Later test should mount FS which trigger journal_replay and orphan_cleanup.
Cool! That would be great if this test case can be added in xfstests.
:-)
Regards,
- Zheng
next prev parent reply other threads:[~2012-12-27 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 0:27 3.8.0-rc1: WARNING: at fs/ext4/page-io.c:232 Alexander Beregalov
2012-12-27 6:29 ` Zheng Liu
2012-12-27 8:04 ` Dmitry Monakhov
2012-12-27 10:33 ` Zheng Liu [this message]
2012-12-27 13:44 ` Theodore Ts'o
2012-12-29 0:21 ` Dave Chinner
2012-12-29 5:04 ` Dmitry Monakhov
2012-12-29 23:23 ` Dave Chinner
2013-01-02 15:17 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121227103342.GA4158@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=a.beregalov@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).