* [PATCH] ext4: fix configuration dependencies for ext4 ACLs and security labels
@ 2013-01-06 3:53 Valerie Aurora
2013-01-06 5:17 ` Tao Ma
2013-01-07 4:07 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Valerie Aurora @ 2013-01-06 3:53 UTC (permalink / raw)
To: linux-ext4
Cc: Valerie Aurora, Theodore Ts'o, David Brown, Eric Sandeen,
Jan Kara, Tao Ma
Commit "ext4: Remove CONFIG_EXT4_FS_XATTR" removed the configuration
dependencies for ext4 xattrs from the ext4 ACLs and security labels
configuration options, but did not replace them with a dependency on
ext4 itself. Add back the dependency on ext4 so the options only show
up if ext4 is enabled.
Signed-off-by: Valerie Aurora <val@vaaconsulting.com>
---
fs/ext4/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
index 0a475c8..9873587 100644
--- a/fs/ext4/Kconfig
+++ b/fs/ext4/Kconfig
@@ -41,6 +41,7 @@ config EXT4_USE_FOR_EXT23
config EXT4_FS_POSIX_ACL
bool "Ext4 POSIX Access Control Lists"
+ depends on EXT4_FS
select FS_POSIX_ACL
help
POSIX Access Control Lists (ACLs) support permissions for users and
@@ -53,6 +54,7 @@ config EXT4_FS_POSIX_ACL
config EXT4_FS_SECURITY
bool "Ext4 Security Labels"
+ depends on EXT4_FS
help
Security labels support alternative access control models
implemented by security modules like SELinux. This option
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fix configuration dependencies for ext4 ACLs and security labels
2013-01-06 3:53 [PATCH] ext4: fix configuration dependencies for ext4 ACLs and security labels Valerie Aurora
@ 2013-01-06 5:17 ` Tao Ma
2013-01-07 4:07 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Tao Ma @ 2013-01-06 5:17 UTC (permalink / raw)
To: Valerie Aurora
Cc: linux-ext4, Theodore Ts'o, David Brown, Eric Sandeen,
Jan Kara, Tao Ma
On 01/06/2013 11:53 AM, Valerie Aurora wrote:
> Commit "ext4: Remove CONFIG_EXT4_FS_XATTR" removed the configuration
> dependencies for ext4 xattrs from the ext4 ACLs and security labels
> configuration options, but did not replace them with a dependency on
> ext4 itself. Add back the dependency on ext4 so the options only show
> up if ext4 is enabled.
>
> Signed-off-by: Valerie Aurora <val@vaaconsulting.com>
Thanks.
Acked-by: Tao Ma <boyu.mt@taobao.com>
> ---
> fs/ext4/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index 0a475c8..9873587 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -41,6 +41,7 @@ config EXT4_USE_FOR_EXT23
>
> config EXT4_FS_POSIX_ACL
> bool "Ext4 POSIX Access Control Lists"
> + depends on EXT4_FS
> select FS_POSIX_ACL
> help
> POSIX Access Control Lists (ACLs) support permissions for users and
> @@ -53,6 +54,7 @@ config EXT4_FS_POSIX_ACL
>
> config EXT4_FS_SECURITY
> bool "Ext4 Security Labels"
> + depends on EXT4_FS
> help
> Security labels support alternative access control models
> implemented by security modules like SELinux. This option
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: fix configuration dependencies for ext4 ACLs and security labels
2013-01-06 3:53 [PATCH] ext4: fix configuration dependencies for ext4 ACLs and security labels Valerie Aurora
2013-01-06 5:17 ` Tao Ma
@ 2013-01-07 4:07 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2013-01-07 4:07 UTC (permalink / raw)
To: Valerie Aurora; +Cc: linux-ext4, David Brown, Eric Sandeen, Jan Kara, Tao Ma
On Sat, Jan 05, 2013 at 07:53:09PM -0800, Valerie Aurora wrote:
> Commit "ext4: Remove CONFIG_EXT4_FS_XATTR" removed the configuration
> dependencies for ext4 xattrs from the ext4 ACLs and security labels
> configuration options, but did not replace them with a dependency on
> ext4 itself. Add back the dependency on ext4 so the options only show
> up if ext4 is enabled.
>
> Signed-off-by: Valerie Aurora <val@vaaconsulting.com>
Thanks Val, for catching this! I've queued this on the ext4 tree.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-07 4:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-06 3:53 [PATCH] ext4: fix configuration dependencies for ext4 ACLs and security labels Valerie Aurora
2013-01-06 5:17 ` Tao Ma
2013-01-07 4:07 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).