From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Guo Chao <yan@linux.vnet.ibm.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] ext4: release buffer in failed path in dx_probe()
Date: Sun, 6 Jan 2013 23:24:52 -0500 [thread overview]
Message-ID: <20130107042451.GB4956@thunk.org> (raw)
In-Reply-To: <20130105194135.GK20106@blackbox.djwong.org>
On Sat, Jan 05, 2013 at 11:41:35AM -0800, Darrick J. Wong wrote:
> On Sat, Jan 05, 2013 at 03:43:00PM +0800, Guo Chao wrote:
> > If checksum fails, we should also release the buffer
> > read from previous iteration.
> >
> > Cc: Darrick J. Wong <darrick.wong@oracle.com>
> > Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
Thanks, applied.
> Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
BTW, technically speaking it should be "Reviewed-by"; that's what I've
used in the commit.
"Acked-by:" gets used when a commit touches multiple subsystem trees.
For example, suppose someone changes a function in fs/direct-io.c,
which also required changes in btrfs, xfs, and ext4. This commit
might go through Al Viro's vfs tree, and might have an Acked-by from
Chris Mason, Dave Chinner, and me, indicating that developers who are
well versed in those trees have agreed that the patches which touched
those other subsystems looked sane.
Since in this case the commit only touches ext4 code, and is going
through the ext4 tree, "Reviewed-by" is what normally gets used.
Cheers,
- Ted
next prev parent reply other threads:[~2013-01-07 4:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 7:42 [PATCH 1/3] ext4: report error if things go wrong when do checksum Guo Chao
2013-01-05 7:43 ` [PATCH 2/3] ext4: release buffer in failed path in dx_probe() Guo Chao
2013-01-05 19:41 ` Darrick J. Wong
2013-01-07 4:24 ` Theodore Ts'o [this message]
2013-01-05 7:43 ` [PATCH 3/3] ext4: remove duplicate assignment in ext4_init_new_dir() Guo Chao
2013-01-05 8:05 ` Tao Ma
2013-01-07 4:37 ` Theodore Ts'o
2013-01-05 19:50 ` [PATCH 1/3] ext4: report error if things go wrong when do checksum Darrick J. Wong
2013-01-06 2:37 ` Guo Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107042451.GB4956@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=yan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).