* [PATCH] mke2fs: check extents feature when bigalloc feature is enabled
@ 2013-01-06 12:25 Zheng Liu
2013-01-08 15:36 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Liu @ 2013-01-06 12:25 UTC (permalink / raw)
To: linux-ext4; +Cc: Zheng Liu
From: Zheng Liu <wenqing.lz@taobao.com>
When bigalloc feature is enabled in mkfs, extents feature also needs to be
enabled. But now when bigalloc feature is enabled without extents feature,
users will not get any warning messages until they try to mount this file
system.
Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
misc/mke2fs.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index a288147..713eb21 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -1988,6 +1988,15 @@ profile_error:
fs_param.s_feature_ro_compat &=
~EXT4_FEATURE_RO_COMPAT_GDT_CSUM;
+ /* Can't support bigalloc feature without extents feature */
+ if ((fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) &&
+ !(fs_param.s_feature_incompat & EXT3_FEATURE_INCOMPAT_EXTENTS)) {
+ com_err(program_name, 0,
+ _("Can't support bigalloc feature without "
+ "extents feature"));
+ exit(1);
+ }
+
/* Since sparse_super is the default, we would only have a problem
* here if it was explicitly disabled.
*/
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mke2fs: check extents feature when bigalloc feature is enabled
2013-01-06 12:25 [PATCH] mke2fs: check extents feature when bigalloc feature is enabled Zheng Liu
@ 2013-01-08 15:36 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-01-08 15:36 UTC (permalink / raw)
To: Zheng Liu; +Cc: linux-ext4, Zheng Liu
On Sun, Jan 06, 2013 at 08:25:17PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> When bigalloc feature is enabled in mkfs, extents feature also needs to be
> enabled. But now when bigalloc feature is enabled without extents feature,
> users will not get any warning messages until they try to mount this file
> system.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-08 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-06 12:25 [PATCH] mke2fs: check extents feature when bigalloc feature is enabled Zheng Liu
2013-01-08 15:36 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).