From: Carlos Maiolino <cmaiolino@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>, esandeen@redhat.com
Subject: Re: [PATCH] ext4: trigger the lazy inode table initialization after resize
Date: Mon, 14 Jan 2013 11:04:15 -0200 [thread overview]
Message-ID: <20130114130415.GB3906@andromeda.usersys.redhat.com> (raw)
In-Reply-To: <1358084571-3042-1-git-send-email-tytso@mit.edu>
Hi,
> @@ -358,6 +361,7 @@ group_add_out:
> ext4_fsblk_t n_blocks_count;
> struct super_block *sb = inode->i_sb;
> int err = 0, err2 = 0;
> + ext4_group_t o_group = EXT4_SB(sb)->s_groups_count;
>
> if (EXT4_HAS_RO_COMPAT_FEATURE(sb,
> EXT4_FEATURE_RO_COMPAT_BIGALLOC)) {
> @@ -388,6 +392,11 @@ group_add_out:
> if (err == 0)
> err = err2;
> mnt_drop_write_file(filp);
> + if (!err && (o_group > EXT4_SB(sb)->s_groups_count) &&
Maybe a n00b question Ted, but can o_group here be bigger than ->s_groups_count
in any chance?
The patch looks good,
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
--
Carlos
next prev parent reply other threads:[~2013-01-14 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 0:07 new block group bitmaps not being initialized after resize!? Carlos Maiolino
2013-01-11 1:07 ` Eric Sandeen
2013-01-11 6:44 ` Andreas Dilger
2013-01-11 15:47 ` Eric Sandeen
2013-01-13 4:36 ` Theodore Ts'o
2013-01-13 5:26 ` Eric Sandeen
2013-01-13 13:37 ` Theodore Ts'o
2013-01-13 13:42 ` [PATCH] ext4: trigger the lazy inode table initialization after resize Theodore Ts'o
2013-01-14 13:04 ` Carlos Maiolino [this message]
2013-01-14 14:33 ` Theodore Ts'o
2013-01-14 14:42 ` Carlos Maiolino
2013-01-14 14:45 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114130415.GB3906@andromeda.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=esandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).