From: Carlos Maiolino <cmaiolino@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>, esandeen@redhat.com
Subject: Re: [PATCH] ext4: trigger the lazy inode table initialization after resize
Date: Mon, 14 Jan 2013 12:42:01 -0200 [thread overview]
Message-ID: <20130114144201.GA10537@andromeda.usersys.redhat.com> (raw)
In-Reply-To: <20130114143317.GE12052@thunk.org>
On Mon, Jan 14, 2013 at 09:33:17AM -0500, Theodore Ts'o wrote:
> On Mon, Jan 14, 2013 at 11:04:15AM -0200, Carlos Maiolino wrote:
> > > @@ -388,6 +392,11 @@ group_add_out:
> > > if (err == 0)
> > > err = err2;
> > > mnt_drop_write_file(filp);
> > > + if (!err && (o_group > EXT4_SB(sb)->s_groups_count) &&
> >
> > Maybe a n00b question Ted, but can o_group here be bigger than ->s_groups_count
> > in any chance?
>
> o_group can never be smaller than s_groups_count (since we don't
> support online shrink). o_group can be larger than s_groups_count if
> ext4_resize_fs() has added one or more block groups to the file system
> --- which is when we might need to kick off the lazy init thread.
>
Thanks to catch the right question :)
> Cheers,
>
> - Ted
--
Carlos
next prev parent reply other threads:[~2013-01-14 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 0:07 new block group bitmaps not being initialized after resize!? Carlos Maiolino
2013-01-11 1:07 ` Eric Sandeen
2013-01-11 6:44 ` Andreas Dilger
2013-01-11 15:47 ` Eric Sandeen
2013-01-13 4:36 ` Theodore Ts'o
2013-01-13 5:26 ` Eric Sandeen
2013-01-13 13:37 ` Theodore Ts'o
2013-01-13 13:42 ` [PATCH] ext4: trigger the lazy inode table initialization after resize Theodore Ts'o
2013-01-14 13:04 ` Carlos Maiolino
2013-01-14 14:33 ` Theodore Ts'o
2013-01-14 14:42 ` Carlos Maiolino [this message]
2013-01-14 14:45 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114144201.GA10537@andromeda.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=esandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).