From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH 1/2 v2] libext2fs: introduce lseek SEEK_DATA/HOLE
Date: Mon, 14 Jan 2013 22:23:29 -0500 [thread overview]
Message-ID: <20130115032329.GC31857@thunk.org> (raw)
In-Reply-To: <1358173111-10511-1-git-send-email-wenqing.lz@taobao.com>
On Mon, Jan 14, 2013 at 10:18:30PM +0800, Zheng Liu wrote:
>
> ext2fs_file_llseek_data/hole() seem to be weird because ext2_file_t
> structure is hidden by a typedef. The caller can not dereference
> it. So I define a marco called EXT2_SEEK_OFFSET_INVALID to let the
> caller indicate that it find the data/hole from ext2_file_t->pos or
> from offset. What do you think?
Is the problem you're worried about is that the user can't get current
location?
That's pretty easy to solve. You can get it the same way it works
with the lseek(2) system call.
retval = ext2fs_file_llseek(file, 0, SEEK_CUR, &pos);
Upon the return, pos will be contain the current file offset.
- Ted
next prev parent reply other threads:[~2013-01-15 3:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 14:18 [PATCH 1/2 v2] libext2fs: introduce lseek SEEK_DATA/HOLE Zheng Liu
2013-01-14 14:18 ` [PATCH 2/2 v2] debugfs: dump a sparse file Zheng Liu
2013-01-15 3:23 ` Theodore Ts'o [this message]
2013-01-15 13:02 ` [PATCH 1/2 v2] libext2fs: introduce lseek SEEK_DATA/HOLE Zheng Liu
2013-01-15 18:55 ` Theodore Ts'o
2013-01-16 12:04 ` Zheng Liu
2013-01-16 14:59 ` Theodore Ts'o
2013-01-18 10:07 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115032329.GC31857@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).