* [PATCH 1/4] ext4: Fix possible use-after-free with AIO [not found] <1358945780-23661-1-git-send-email-jack@suse.cz> @ 2013-01-23 12:56 ` Jan Kara 2013-01-23 13:18 ` Carlos Maiolino 0 siblings, 1 reply; 4+ messages in thread From: Jan Kara @ 2013-01-23 12:56 UTC (permalink / raw) To: linux-fsdevel; +Cc: tytso, bpm, jlbec, Jan Kara, linux-ext4, stable Running AIO is pinning inode in memory using file reference. Once AIO is completed using aio_complete(), file reference is put and inode can be freed from memory. So we have to be sure that calling aio_complete() is the last thing we do with the inode. CC: linux-ext4@vger.kernel.org CC: "Theodore Ts'o" <tytso@mit.edu> CC: stable@vger.kernel.org Signed-off-by: Jan Kara <jack@suse.cz> --- fs/ext4/inode.c | 2 +- fs/ext4/page-io.c | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index cbfe13b..ba06638 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2977,9 +2977,9 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, if (!(io_end->flag & EXT4_IO_END_UNWRITTEN)) { ext4_free_io_end(io_end); out: + inode_dio_done(inode); if (is_async) aio_complete(iocb, ret, 0); - inode_dio_done(inode); return; } diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 0016fbc..b42d04f 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -103,14 +103,13 @@ static int ext4_end_io(ext4_io_end_t *io) "(inode %lu, offset %llu, size %zd, error %d)", inode->i_ino, offset, size, ret); } - if (io->iocb) - aio_complete(io->iocb, io->result, 0); - - if (io->flag & EXT4_IO_END_DIRECT) - inode_dio_done(inode); /* Wake up anyone waiting on unwritten extent conversion */ if (atomic_dec_and_test(&EXT4_I(inode)->i_unwritten)) wake_up_all(ext4_ioend_wq(inode)); + if (io->flag & EXT4_IO_END_DIRECT) + inode_dio_done(inode); + if (io->iocb) + aio_complete(io->iocb, io->result, 0); return ret; } -- 1.7.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] ext4: Fix possible use-after-free with AIO 2013-01-23 12:56 ` [PATCH 1/4] ext4: Fix possible use-after-free with AIO Jan Kara @ 2013-01-23 13:18 ` Carlos Maiolino 0 siblings, 0 replies; 4+ messages in thread From: Carlos Maiolino @ 2013-01-23 13:18 UTC (permalink / raw) To: Jan Kara; +Cc: linux-fsdevel, tytso, bpm, jlbec, linux-ext4, stable Looks Good, Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> On Wed, Jan 23, 2013 at 01:56:17PM +0100, Jan Kara wrote: > Running AIO is pinning inode in memory using file reference. Once AIO > is completed using aio_complete(), file reference is put and inode can > be freed from memory. So we have to be sure that calling aio_complete() > is the last thing we do with the inode. > > CC: linux-ext4@vger.kernel.org > CC: "Theodore Ts'o" <tytso@mit.edu> > CC: stable@vger.kernel.org > Signed-off-by: Jan Kara <jack@suse.cz> > --- > fs/ext4/inode.c | 2 +- > fs/ext4/page-io.c | 9 ++++----- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index cbfe13b..ba06638 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -2977,9 +2977,9 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, > if (!(io_end->flag & EXT4_IO_END_UNWRITTEN)) { > ext4_free_io_end(io_end); > out: > + inode_dio_done(inode); > if (is_async) > aio_complete(iocb, ret, 0); > - inode_dio_done(inode); > return; > } > > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index 0016fbc..b42d04f 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -103,14 +103,13 @@ static int ext4_end_io(ext4_io_end_t *io) > "(inode %lu, offset %llu, size %zd, error %d)", > inode->i_ino, offset, size, ret); > } > - if (io->iocb) > - aio_complete(io->iocb, io->result, 0); > - > - if (io->flag & EXT4_IO_END_DIRECT) > - inode_dio_done(inode); > /* Wake up anyone waiting on unwritten extent conversion */ > if (atomic_dec_and_test(&EXT4_I(inode)->i_unwritten)) > wake_up_all(ext4_ioend_wq(inode)); > + if (io->flag & EXT4_IO_END_DIRECT) > + inode_dio_done(inode); > + if (io->iocb) > + aio_complete(io->iocb, io->result, 0); > return ret; > } > > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Carlos ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 0/4 v2] Fix possible use after free with AIO @ 2013-01-29 23:27 Jan Kara 2013-01-29 23:27 ` [PATCH 1/4] ext4: Fix possible use-after-free " Jan Kara 0 siblings, 1 reply; 4+ messages in thread From: Jan Kara @ 2013-01-29 23:27 UTC (permalink / raw) To: Al Viro; +Cc: linux-fsdevel, linux-ext4, ocfs2-devel, xfs Hi, since nobody seem to have picked up any of the patches (at least nobody told me so), I've added acks I received to the patches and I'm sending them to Al for merging. Al, can you please merge these? Thanks. Honza _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/4] ext4: Fix possible use-after-free with AIO 2013-01-29 23:27 [PATCH 0/4 v2] Fix possible use after free " Jan Kara @ 2013-01-29 23:27 ` Jan Kara 2013-01-30 3:51 ` Theodore Ts'o 0 siblings, 1 reply; 4+ messages in thread From: Jan Kara @ 2013-01-29 23:27 UTC (permalink / raw) To: Al Viro Cc: linux-fsdevel, xfs, linux-ext4, ocfs2-devel, Jan Kara, Theodore Ts'o, stable Running AIO is pinning inode in memory using file reference. Once AIO is completed using aio_complete(), file reference is put and inode can be freed from memory. So we have to be sure that calling aio_complete() is the last thing we do with the inode. CC: linux-ext4@vger.kernel.org CC: "Theodore Ts'o" <tytso@mit.edu> CC: stable@vger.kernel.org Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> Acked-by: Jeff Moyer <jmoyer@redhat.com> Signed-off-by: Jan Kara <jack@suse.cz> --- fs/ext4/inode.c | 2 +- fs/ext4/page-io.c | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index cbfe13b..ba06638 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2977,9 +2977,9 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, if (!(io_end->flag & EXT4_IO_END_UNWRITTEN)) { ext4_free_io_end(io_end); out: + inode_dio_done(inode); if (is_async) aio_complete(iocb, ret, 0); - inode_dio_done(inode); return; } diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 0016fbc..b42d04f 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -103,14 +103,13 @@ static int ext4_end_io(ext4_io_end_t *io) "(inode %lu, offset %llu, size %zd, error %d)", inode->i_ino, offset, size, ret); } - if (io->iocb) - aio_complete(io->iocb, io->result, 0); - - if (io->flag & EXT4_IO_END_DIRECT) - inode_dio_done(inode); /* Wake up anyone waiting on unwritten extent conversion */ if (atomic_dec_and_test(&EXT4_I(inode)->i_unwritten)) wake_up_all(ext4_ioend_wq(inode)); + if (io->flag & EXT4_IO_END_DIRECT) + inode_dio_done(inode); + if (io->iocb) + aio_complete(io->iocb, io->result, 0); return ret; } -- 1.7.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] ext4: Fix possible use-after-free with AIO 2013-01-29 23:27 ` [PATCH 1/4] ext4: Fix possible use-after-free " Jan Kara @ 2013-01-30 3:51 ` Theodore Ts'o 0 siblings, 0 replies; 4+ messages in thread From: Theodore Ts'o @ 2013-01-30 3:51 UTC (permalink / raw) To: Jan Kara; +Cc: Al Viro, linux-fsdevel, xfs, linux-ext4, ocfs2-devel, stable On Wed, Jan 30, 2013 at 12:27:58AM +0100, Jan Kara wrote: > Running AIO is pinning inode in memory using file reference. Once AIO > is completed using aio_complete(), file reference is put and inode can > be freed from memory. So we have to be sure that calling aio_complete() > is the last thing we do with the inode. > > CC: linux-ext4@vger.kernel.org > CC: "Theodore Ts'o" <tytso@mit.edu> > CC: stable@vger.kernel.org > Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> > Acked-by: Jeff Moyer <jmoyer@redhat.com> > Signed-off-by: Jan Kara <jack@suse.cz> I've picked up the ext4 change. Sorry for not getting to this sooner. - Ted ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-30 3:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1358945780-23661-1-git-send-email-jack@suse.cz>
2013-01-23 12:56 ` [PATCH 1/4] ext4: Fix possible use-after-free with AIO Jan Kara
2013-01-23 13:18 ` Carlos Maiolino
2013-01-29 23:27 [PATCH 0/4 v2] Fix possible use after free " Jan Kara
2013-01-29 23:27 ` [PATCH 1/4] ext4: Fix possible use-after-free " Jan Kara
2013-01-30 3:51 ` Theodore Ts'o
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).