From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole feature in fallocate
Date: Thu, 24 Jan 2013 22:32:01 -0500 [thread overview]
Message-ID: <20130125033201.GD28908@thunk.org> (raw)
In-Reply-To: <1358493381-20150-2-git-send-email-wenqing.lz@taobao.com>
On Fri, Jan 18, 2013 at 03:16:21PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> After adding indirect punching hole feature, we need to enable it in fallocate.
> For this purpose, some sanity checks need to be adjusted. Currently we need to
> check FALLOC_FL_PUNCH_HOLE flag before other sanity checks.
I've folded these two patches into one since the first patch in this
series since there won't be any way to exercise the new code paths
until we enable this in fallocate(), and it doesn't really change
existing code paths. If it did make huge changes in the normal code
path, it might be useful to keep the two commits separate, but that's
not the case here.
Anyway, they look good so I've checked them into my tree. I'm
currently kicking off a test run to make sure there aren't any
problems except for the test 255 failure when testing w/o extents, but
I don't really anticipate any issues.
Thanks!!
- Ted
next prev parent reply other threads:[~2013-01-25 3:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 7:16 [RESEND][PATCH 1/2 v2] ext4: add indirect punching hole support Zheng Liu
2013-01-18 7:16 ` [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole feature in fallocate Zheng Liu
2013-01-25 3:32 ` Theodore Ts'o [this message]
2013-01-25 3:59 ` Zheng Liu
2013-01-25 4:21 ` Theodore Ts'o
2013-01-26 0:47 ` Dave Chinner
2013-01-28 5:04 ` Zheng Liu
2013-01-28 4:57 ` Theodore Ts'o
2013-01-28 5:16 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125033201.GD28908@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).