Re: [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole feature in fallocate

[Theodore Ts'o <tytso@mit.edu>]

On Fri, Jan 25, 2013 at 11:59:12AM +0800, Zheng Liu wrote:
> 
> I wonder that maybe we need to submit a patch to let xfstest understand
> that a filesystem supports extents or not because after applied this
> patch indirect-based file in ext4 has supported seek_data/hole and hole
> punching.  I usually run xfstest automatically, and every time I need
> to check the result of #255 and #285 manually.  That is annoying for me.

I would think the right thing to do is to have xfstests make sure it
understands that fallocate working with FALLOC_FL_PUNCH_HOLE does not
imply that fallocate without the FALLOC_FL_PUNCH_HOLE flag OR'ed in
will work.  It should test for support for preallocation and hole
punching separately, and do tests accordingly.

That way we don't have to add explicit ext4 knowledge/logic to
xfstests.  (Maybe in the future there will be some other file system
which supports punch hole but not preallocate, and it might not be
based on whether or not the file is using ext4 extents or not.)

Cheers,

						- Ted