From: Theodore Ts'o <tytso@mit.edu>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [ext4:dev 6/9] fs/ext4/super.c:4039:1: warning: label 'failed_mount8' defined but not used
Date: Thu, 24 Jan 2013 23:24:45 -0500 [thread overview]
Message-ID: <20130125042445.GH28908@thunk.org> (raw)
In-Reply-To: <51020468.kToCHrt5WwL/Cp68%fengguang.wu@intel.com>
On Fri, Jan 25, 2013 at 12:04:56PM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
> head: a16d0247541d300a1a1027212725c86a16180a0a
> commit: 99d0e4f8d1d88b303219c50b3a2c1192eab6b3e2 [6/9] ext4: release sysfs kobject when failing to enable quotas on mount
> config: x86_64-randconfig-x988 (attached as .config)
>
> All warnings:
>
> fs/ext4/super.c: In function 'ext4_fill_super':
> >> fs/ext4/super.c:4039:1: warning: label 'failed_mount8' defined but not used [-Wunused-label]
Sigh.... I'll add the following to make this go away.
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 96a3cc9..3ac3060 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4036,8 +4036,10 @@ cantfind_ext4:
ext4_msg(sb, KERN_ERR, "VFS: Can't find ext4 filesystem");
goto failed_mount;
+#ifdef CONFIG_QUOTA
failed_mount8:
kobject_del(&sbi->s_kobj);
+#endif
failed_mount7:
ext4_unregister_li_request(sb);
failed_mount6:
- Ted
prev parent reply other threads:[~2013-01-25 4:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 4:04 [ext4:dev 6/9] fs/ext4/super.c:4039:1: warning: label 'failed_mount8' defined but not used kbuild test robot
2013-01-25 4:24 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125042445.GH28908@thunk.org \
--to=tytso@mit.edu \
--cc=fengguang.wu@intel.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).