From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>,
xfs@oss.sgi.com
Subject: Re: [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole feature in fallocate
Date: Sat, 26 Jan 2013 11:47:07 +1100 [thread overview]
Message-ID: <20130126004707.GG2667@dastard> (raw)
In-Reply-To: <20130125042122.GG28908@thunk.org>
[cc xfs@oss.sgi.com]
On Thu, Jan 24, 2013 at 11:21:22PM -0500, Theodore Ts'o wrote:
> On Fri, Jan 25, 2013 at 11:59:12AM +0800, Zheng Liu wrote:
> >
> > I wonder that maybe we need to submit a patch to let xfstest understand
> > that a filesystem supports extents or not because after applied this
> > patch indirect-based file in ext4 has supported seek_data/hole and hole
> > punching. I usually run xfstest automatically, and every time I need
> > to check the result of #255 and #285 manually. That is annoying for me.
>
> I would think the right thing to do is to have xfstests make sure it
> understands that fallocate working with FALLOC_FL_PUNCH_HOLE does not
> imply that fallocate without the FALLOC_FL_PUNCH_HOLE flag OR'ed in
> will work.
We already have this capabiity in xfstests via
_require_xfs_io_falloc_punch and _require_xfs_io_falloc. That,
however, doesn't mean the tests that use these calls do the correct
requirement checks. That's the problem with 255 - it doesn't call
_require_xfs_io_falloc.
As to 285, the seek_sanity_test does it's own check for seek
hole/data support, and error out if it fails. This needs to be
turned into an equivalent _require_seek_hole_data (e.g. by running
"seek_sanity_test -t" to test for support) and 285 needs to the call
the _require_seek_hole_data before running the test proper.
Please send patches to xfs@oss.sgi.com....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2013-01-26 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 7:16 [RESEND][PATCH 1/2 v2] ext4: add indirect punching hole support Zheng Liu
2013-01-18 7:16 ` [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole feature in fallocate Zheng Liu
2013-01-25 3:32 ` Theodore Ts'o
2013-01-25 3:59 ` Zheng Liu
2013-01-25 4:21 ` Theodore Ts'o
2013-01-26 0:47 ` Dave Chinner [this message]
2013-01-28 5:04 ` Zheng Liu
2013-01-28 4:57 ` Theodore Ts'o
2013-01-28 5:16 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130126004707.GG2667@dastard \
--to=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).