From: Theodore Ts'o <tytso@mit.edu>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Ext4: remove a useless check for the function ext4_data_block_valid
Date: Sun, 27 Jan 2013 07:38:31 -0500 [thread overview]
Message-ID: <20130127123831.GC23996@thunk.org> (raw)
In-Reply-To: <5105CA65.7020504@gmail.com>
On Sun, Jan 27, 2013 at 04:46:29PM -0800, Wang Shilong wrote:
> > Actually, it can be true --- if start_blk + count (which are both
> > unsigned integers) overflows....
> Yeah,you are right....
> I am sorry,I miss the overflow condition...
We added it because we saw a crash that was a caused by an overflow,
if memory serves correctly. Or maybe it was a mysterious data or file
system corruption that was incredibly painful to find.
Fun trivia fact: the European Space Agency had the Ariane 5 rocket
explode on its maiden flight due to a integer overflow bug.
- Ted
next prev parent reply other threads:[~2013-01-27 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 22:57 [PATCH] Ext4: remove a useless check for the function ext4_data_block_valid Wang Shilong
2013-01-26 15:38 ` Theodore Ts'o
2013-01-28 0:46 ` Wang Shilong
2013-01-27 12:38 ` Theodore Ts'o [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 22:55 Wang Shilong
2011-01-26 22:45 Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127123831.GC23996@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).