From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Guo Chao <yan@linux.vnet.ibm.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/4] ext4: remove useless assignment in dx_probe()
Date: Mon, 28 Jan 2013 17:21:50 -0800 [thread overview]
Message-ID: <20130129012150.GB4754@blackbox.djwong.org> (raw)
In-Reply-To: <1358496074-6228-3-git-send-email-yan@linux.vnet.ibm.com>
On Fri, Jan 18, 2013 at 04:01:13PM +0800, Guo Chao wrote:
> No body care about the effect of this assignment.
>
> Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
> ---
> fs/ext4/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index b3717a3..e35ea3d 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -714,7 +714,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir,
> *err = ERR_BAD_DX_DIR;
> goto fail2;
> }
> - at = entries = ((struct dx_node *) bh->b_data)->entries;
> + entries = ((struct dx_node *) bh->b_data)->entries;
The 'at' variable seems to be used (in a if(0)'d code block) to check the
results of the binary search against a slow linear search. Perhaps we should
get rid of the if(0) hunk about 30 lines up? The 'at' variable itself could go
too, since it seems to be an alias of "p - 1" and frame->at.
--D
>
> if (!buffer_verified(bh) &&
> !ext4_dx_csum_verify(dir,
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-29 1:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 8:01 [PATCH 1/4] ext4: release buffer when checksum failed Guo Chao
2013-01-18 8:01 ` [PATCH 2/4] ext4: remove unused variable in add_dirent_to_buf() Guo Chao
2013-01-29 1:12 ` Darrick J. Wong
2013-01-29 2:28 ` Theodore Ts'o
2013-01-18 8:01 ` [PATCH 3/4] ext4: remove useless assignment in dx_probe() Guo Chao
2013-01-29 1:21 ` Darrick J. Wong [this message]
2013-01-29 2:37 ` Theodore Ts'o
2013-01-29 2:35 ` Theodore Ts'o
2013-01-18 8:01 ` [PATCH 4/4] ext4: remove unnecessary NULL pointer check Guo Chao
2013-01-29 1:24 ` Darrick J. Wong
2013-01-29 2:40 ` Guo Chao
2013-01-29 2:42 ` Theodore Ts'o
2013-01-18 21:28 ` [PATCH 1/4] ext4: release buffer when checksum failed Darrick J. Wong
2013-01-29 2:25 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129012150.GB4754@blackbox.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).