From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: remove explicit WARN_ON when ext4_map_blocks() fails
Date: Mon, 28 Jan 2013 21:22:21 -0500 [thread overview]
Message-ID: <20130129022221.GE7003@thunk.org> (raw)
In-Reply-To: <1359364447-4699-1-git-send-email-lczerner@redhat.com>
On Mon, Jan 28, 2013 at 10:14:07AM +0100, Lukas Czerner wrote:
> In two places we call WARN_ON() before we print out the debug message,
> however we agreed that the WARN_ON() is unnecessary at those places so
> remove them.
>
> Also use ext4_warning() instead of ext4_msg() and printk().
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2013-01-29 2:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 9:14 [PATCH] ext4: remove explicit WARN_ON when ext4_map_blocks() fails Lukas Czerner
2013-01-29 2:22 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129022221.GE7003@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).