* [PATCH] ext4: only define label failed_mount8 when used
@ 2013-01-30 0:09 Stephen Warren
2013-01-30 3:52 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Warren @ 2013-01-30 0:09 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger
Cc: linux-ext4, linux-kernel, Stephen Warren
From: Stephen Warren <swarren@nvidia.com>
This fixes:
fs/ext4/super.c: In function 'ext4_fill_super':
fs/ext4/super.c:4040:1: warning: label 'failed_mount8' defined but not used
This label is only jumped to by code under ifdef CONFIG_QUOTA, so only
define the label in that case too.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
fs/ext4/super.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 861ffa0..3b04d15 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4037,8 +4037,10 @@ cantfind_ext4:
ext4_msg(sb, KERN_ERR, "VFS: Can't find ext4 filesystem");
goto failed_mount;
+#ifdef CONFIG_QUOTA
failed_mount8:
kobject_del(&sbi->s_kobj);
+#endif
failed_mount7:
ext4_unregister_li_request(sb);
failed_mount6:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: only define label failed_mount8 when used
2013-01-30 0:09 [PATCH] ext4: only define label failed_mount8 when used Stephen Warren
@ 2013-01-30 3:52 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-01-30 3:52 UTC (permalink / raw)
To: Stephen Warren; +Cc: Andreas Dilger, linux-ext4, linux-kernel, Stephen Warren
On Tue, Jan 29, 2013 at 05:09:00PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> This fixes:
>
> fs/ext4/super.c: In function 'ext4_fill_super':
> fs/ext4/super.c:4040:1: warning: label 'failed_mount8' defined but not used
>
> This label is only jumped to by code under ifdef CONFIG_QUOTA, so only
> define the label in that case too.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
This is already fixed in the ext4 dev tree. I assume you noticed this
in linux-next? It should be fixed up in tomorrow's cut.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-30 3:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-30 0:09 [PATCH] ext4: only define label failed_mount8 when used Stephen Warren
2013-01-30 3:52 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).