From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH 9/16] fs/ext4/indirect.c: use WARN Date: Fri, 1 Feb 2013 20:07:37 -0500 Message-ID: <20130202010737.GA9892@thunk.org> References: <1351940317-14812-1-git-send-email-Julia.Lawall@lip6.fr> <1351940317-14812-10-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kernel-janitors@vger.kernel.org, Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org To: Julia Lawall Return-path: Received: from li9-11.members.linode.com ([67.18.176.11]:46566 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756771Ab3BBBHo (ORCPT ); Fri, 1 Feb 2013 20:07:44 -0500 Content-Disposition: inline In-Reply-To: <1351940317-14812-10-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sat, Nov 03, 2012 at 11:58:30AM +0100, Julia Lawall wrote: > From: Julia Lawall > > Use WARN rather than printk followed by WARN_ON(1), for conciseness. > > A simplified version of the semantic patch that makes this transformation > is as follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression list es; > @@ > > -printk( > +WARN(1, > es); > -WARN_ON(1); > // > > Signed-off-by: Julia Lawall Thanks, applied. - Ted