From: Jan Kara <jack@suse.cz>
To: Wang shilong <wangshilong1991@gmail.com>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org,
Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Subject: Re: [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new_blocks
Date: Wed, 6 Feb 2013 13:46:12 +0100 [thread overview]
Message-ID: <20130206124612.GC6330@quack.suse.cz> (raw)
In-Reply-To: <1360131268-1615-1-git-send-email-wangshilong1991@gmail.com>
On Wed 06-02-13 14:14:26, Wang shilong wrote:
> From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
>
> It can be guranteed that inode->i_sb should not be null in vfs.
> So here the check about it is overhead.
This patch looks good. I've added it to my tree.
Honza
>
> Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
> ---
> fs/ext2/balloc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index 1c36139..22993a0 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -1239,10 +1239,6 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,
>
> *errp = -ENOSPC;
> sb = inode->i_sb;
> - if (!sb) {
> - printk("ext2_new_blocks: nonexistent device");
> - return 0;
> - }
>
> /*
> * Check quota for allocation of this block.
> --
> 1.7.11.7
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-02-06 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 6:14 [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new_blocks Wang shilong
2013-02-06 6:14 ` [PATCH 2/3] Ext2: mark inode dirty after the function dquot_free_block_nodirty is called Wang shilong
2013-02-06 12:44 ` Jan Kara
2013-02-06 6:14 ` [PATCH 3/3] Ext2: remove the static function release_blocks to optimize the kernel Wang shilong
2013-02-06 12:48 ` Jan Kara
2013-02-06 12:46 ` Jan Kara [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-06 20:01 [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new_blocks Wang Shilong
2013-02-06 20:22 Wang Shilong
2013-02-06 6:56 ` Zheng Liu
2013-02-06 18:29 ` Theodore Ts'o
2013-02-07 15:22 ` shilong wang
2013-02-08 4:54 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206124612.GC6330@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
--cc=wangsl-fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).