From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 02/12] jbd2: revert "jbd2: add COW fields to struct jbd2_journal_handle"
Date: Mon, 11 Feb 2013 16:58:36 +0100 [thread overview]
Message-ID: <20130211155836.GH5318@quack.suse.cz> (raw)
In-Reply-To: <1360446832-12724-3-git-send-email-tytso@mit.edu>
On Sat 09-02-13 16:53:42, Ted Tso wrote:
> This reverts commit 93737456d68ddcb86232f669b83da673dd12e351.
>
> The cow-snapshots effort is no longer active, so remove these extra
> fields to shrink down the handle structure.
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
> include/linux/jbd2.h | 28 +++-------------------------
> 1 file changed, 3 insertions(+), 25 deletions(-)
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index e0aafc4..24db725 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -397,35 +397,13 @@ struct jbd2_journal_handle
> int h_err;
>
> /* Flags [no locking] */
> - unsigned int h_sync:1; /* sync-on-close */
> - unsigned int h_jdata:1; /* force data journaling */
> - unsigned int h_aborted:1; /* fatal error on handle */
> - unsigned int h_cowing:1; /* COWing block to snapshot */
> -
> - /* Number of buffers requested by user:
> - * (before adding the COW credits factor) */
> - unsigned int h_base_credits:14;
> -
> - /* Number of buffers the user is allowed to dirty:
> - * (counts only buffers dirtied when !h_cowing) */
> - unsigned int h_user_credits:14;
> -
> + unsigned int h_sync: 1; /* sync-on-close */
> + unsigned int h_jdata: 1; /* force data journaling */
> + unsigned int h_aborted: 1; /* fatal error on handle */
>
> #ifdef CONFIG_DEBUG_LOCK_ALLOC
> struct lockdep_map h_lockdep_map;
> #endif
> -
> -#ifdef CONFIG_JBD2_DEBUG
> - /* COW debugging counters: */
> - unsigned int h_cow_moved; /* blocks moved to snapshot */
> - unsigned int h_cow_copied; /* blocks copied to snapshot */
> - unsigned int h_cow_ok_jh; /* blocks already COWed during current
> - transaction */
> - unsigned int h_cow_ok_bitmap; /* blocks not set in COW bitmap */
> - unsigned int h_cow_ok_mapped;/* blocks already mapped in snapshot */
> - unsigned int h_cow_bitmaps; /* COW bitmaps created */
> - unsigned int h_cow_excluded; /* blocks set in exclude bitmap */
> -#endif
> };
>
>
> --
> 1.7.12.rc0.22.gcdd159b
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-02-11 15:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 21:53 [PATCH 00/12] jbd2 optimization and bug fixes Theodore Ts'o
2013-02-09 21:53 ` [PATCH 01/12] jbd2: track request delay statistics Theodore Ts'o
2013-02-11 15:57 ` Jan Kara
2013-02-09 21:53 ` [PATCH 02/12] jbd2: revert "jbd2: add COW fields to struct jbd2_journal_handle" Theodore Ts'o
2013-02-11 15:58 ` Jan Kara [this message]
2013-02-09 21:53 ` [PATCH 03/12] jbd2: add tracepoints which provide per-handle statistics Theodore Ts'o
2013-02-09 21:53 ` [PATCH 04/12] ext4: move the jbd2 wrapper functions out of super.c Theodore Ts'o
2013-02-09 21:53 ` [PATCH 05/12] ext4: pass context information to jbd2__journal_start() Theodore Ts'o
2013-02-11 16:16 ` Jan Kara
2013-02-11 18:13 ` Theodore Ts'o
2013-02-11 19:58 ` Jan Kara
2013-02-11 20:14 ` Theodore Ts'o
2013-02-09 21:53 ` [PATCH 06/12] ext4: grab page before starting transaction handle in write_begin() Theodore Ts'o
2013-02-11 16:35 ` Jan Kara
2013-02-09 21:53 ` [PATCH 07/12] ext4: start handle at the last possible moment in ext4_unlink() Theodore Ts'o
2013-02-11 16:21 ` Jan Kara
2013-02-09 21:53 ` [PATCH 08/12] ext4: start handle at the last possible moment in ext4_rmdir() Theodore Ts'o
2013-02-11 16:22 ` Jan Kara
2013-02-09 21:53 ` [PATCH 09/12] ext4: fix the number of credits needed for ext4_ext_migrate() Theodore Ts'o
2013-02-11 16:26 ` Jan Kara
2013-02-09 21:53 ` [PATCH 10/12] ext4: fix the number of credits needed for ext4_unlink() and ext4_rmdir() Theodore Ts'o
2013-02-11 16:28 ` Jan Kara
2013-02-11 18:30 ` Theodore Ts'o
2013-02-11 19:30 ` Jan Kara
2013-02-09 21:53 ` [PATCH 11/12] ext4: fix the number of credits needed for acl ops with inline data Theodore Ts'o
2013-02-10 13:42 ` Tao Ma
2013-02-10 18:15 ` Shentino
2013-02-10 19:43 ` Theodore Ts'o
2013-02-11 16:16 ` Andreas Dilger
2013-02-11 16:30 ` Jan Kara
2013-02-09 21:53 ` [PATCH 12/12] ext4: start handle at the last possible moment when creating inodes Theodore Ts'o
2013-02-11 1:47 ` Theodore Ts'o
2013-02-11 16:00 ` Andreas Dilger
2013-02-11 15:52 ` [PATCH 00/12] jbd2 optimization and bug fixes Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211155836.GH5318@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).