From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eric Sandeen <sandeen@redhat.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/2] ext4: use module parameters instead of debugfs for mballoc_debug
Date: Tue, 12 Feb 2013 10:14:11 +1100 [thread overview]
Message-ID: <20130211231411.GA10731@dastard> (raw)
In-Reply-To: <20130211155428.GA6001@thunk.org>
On Mon, Feb 11, 2013 at 10:54:28AM -0500, Theodore Ts'o wrote:
> On Mon, Feb 11, 2013 at 09:48:01AM -0600, Eric Sandeen wrote:
> >
> > As another thought, did you consider using dynamic debug for this, or is that
> > too much trickiness? Might be nice since usually a bug reporter won't have
> > a kernel built with CONFIG_EXT4_DEBUG . . .
>
> I had assumed that the long term direction was to use tracepoints,
> which also has the advantage of not requiring kernels built with
> CONFIG_EXT4_DEBUG.
>
> Hmm.... one thing though is if we want bug reporters to use
> tracepoints (as opposed to just developers), we'll need to have some
> pre-made shell scripts to make it easy for non-developers to enable
> tracepoints for various problems.
FYI, we have a quick outline of how to gather a basic event trace
using trace-cmd in the XFS FAQ for this purpose:
http://xfs.org/index.php/XFS_FAQ#Q:_What_information_should_I_include_when_reporting_a_problem.3F
If a more complex/finer grained trace is required to further isolate
the problem, we generally then tell the user exactly what to run as
the events/devices that need to be traced are case-specific. Seeing
the users are already familiar with the basic tracing technique at
this point it seems to work fine...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2013-02-11 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 1:42 [PATCH 1/2] ext4: use module parameters instead of debugfs for mballoc_debug Theodore Ts'o
2013-02-10 1:42 ` [PATCH 2/2] jbd2: use module parameters instead of debugfs for jbd_debug Theodore Ts'o
2013-02-11 15:36 ` [PATCH 1/2] ext4: use module parameters instead of debugfs for mballoc_debug Eric Sandeen
2013-02-11 15:48 ` Eric Sandeen
2013-02-11 15:54 ` Theodore Ts'o
2013-02-11 16:04 ` Eric Sandeen
2013-02-11 23:14 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211231411.GA10731@dastard \
--to=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).