From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Don't allow quota mount options when quota feature enabled
Date: Tue, 26 Feb 2013 14:18:22 +0100 [thread overview]
Message-ID: <20130226131822.GA3359@quack.suse.cz> (raw)
In-Reply-To: <20130226003943.GC7007@thunk.org>
On Mon 25-02-13 19:39:43, Ted Tso wrote:
> On Tue, Feb 26, 2013 at 12:36:08AM +0100, Jan Kara wrote:
> > So far we silently ignored when quota mount options were set while quota
> > feature was enabled. But this can create confusion in userspace when
> > mount options are set but silently ignored and also creates opportunities
> > for bugs when we don't properly test all quota types. Actually
> > ext4_mark_dquot_dirty() forgets to test for quota feature so it was
> > dependent on journaled quota options being set. OTOH ext4_orphan_cleanup()
> > tries to enable journaled quota when quota options are specified which is
> > wrong when quota feature is enabled.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> I've been using the quota mount options since it's the only way to
> test the quota patches when using an older version of the quota
> userspace package.
Yeah, I know it's useful at moments to be able to use quota mount options
even with quota feature. But older quota tools behave strangely with quota
feature anyway at times so for production use I'd suggest at least version
4.01 anyway. That's why I decided forcing quota mount options off with
quota feature because that's going to cause the least confusion long term
IMHO.
> I can build a newer version of the userspace quota package for my own
> use (since version 4.01 isn't in Debian Testing yet nor Ubuntu yet),
> but we probably need to make sure we document that users may need to
> build their own version of the quota package.
True, I guess adding that to mke2fs manpage would be appropriate?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-02-26 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 23:36 [PATCH 1/2] ext4: Don't allow quota mount options when quota feature enabled Jan Kara
2013-02-25 23:36 ` [PATCH 2/2] ext4: Enable quotas before orphan cleanup Jan Kara
2013-03-02 23:04 ` Theodore Ts'o
2013-02-26 0:39 ` [PATCH 1/2] ext4: Don't allow quota mount options when quota feature enabled Theodore Ts'o
2013-02-26 13:18 ` Jan Kara [this message]
2013-03-02 23:04 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226131822.GA3359@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).