From: Borislav Petkov <bp@alien8.de>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Markus Trippelsdorf <markus@trippelsdorf.de>,
"gnehzuil.liu" <gnehzuil.liu@gmail.com>,
Zheng Liu <wenqing.lz@taobao.com>, Dave Jones <davej@redhat.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] ext4 updates for 3.9
Date: Wed, 27 Feb 2013 20:06:23 +0100 [thread overview]
Message-ID: <20130227190623.GH5530@pd.tnic> (raw)
In-Reply-To: <20130227184912.GA19624@thunk.org>
On Wed, Feb 27, 2013 at 01:49:12PM -0500, Theodore Ts'o wrote:
> -#define EXTENT_STATUS_WRITTEN 0x80000000 /* written extent */
> -#define EXTENT_STATUS_UNWRITTEN 0x40000000 /* unwritten extent */
> -#define EXTENT_STATUS_DELAYED 0x20000000 /* delayed extent */
> -#define EXTENT_STATUS_HOLE 0x10000000 /* hole */
> +#define EXTENT_STATUS_WRITTEN (((unsigned long long) 1) << 63)
> +#define EXTENT_STATUS_UNWRITTEN (((unsigned long long) 1) << 62)
> +#define EXTENT_STATUS_DELAYED (((unsigned long long) 1) << 61)
> +#define EXTENT_STATUS_HOLE (((unsigned long long) 1) << 60)
Just a nitpick:
1ULL << ...
is shorter and probably the standard way we do flags.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
prev parent reply other threads:[~2013-02-27 19:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 20:39 [GIT PULL] ext4 updates for 3.9 Theodore Ts'o
2013-02-27 12:47 ` Markus Trippelsdorf
2013-02-27 15:34 ` Theodore Ts'o
2013-02-27 15:44 ` Markus Trippelsdorf
2013-02-27 17:01 ` Markus Trippelsdorf
2013-02-27 17:10 ` gnehzuil.liu
2013-02-27 17:22 ` Markus Trippelsdorf
2013-02-27 17:38 ` gnehzuil.liu
2013-02-27 17:45 ` Markus Trippelsdorf
2013-02-27 17:52 ` Linus Torvalds
2013-02-27 18:49 ` Theodore Ts'o
2013-02-27 18:56 ` Markus Trippelsdorf
2013-02-27 19:19 ` Dave Jones
2013-02-27 19:27 ` Zheng Liu
2013-02-27 19:29 ` Theodore Ts'o
2013-02-27 20:12 ` [GIT PULL URGENT] ext4 regression fix " Linus Torvalds
2013-02-27 20:15 ` Theodore Ts'o
2013-02-27 20:23 ` Linus Torvalds
2013-02-27 20:41 ` Borislav Petkov
2013-03-01 3:30 ` Dave Jones
2013-03-01 4:00 ` Theodore Ts'o
2013-03-01 5:00 ` [PATCH] ext4: optimize ext4_es_shrink() Theodore Ts'o
2013-03-01 16:11 ` Dave Jones
2013-03-01 16:26 ` Theodore Ts'o
2013-03-01 16:40 ` Dave Jones
2013-03-01 16:40 ` Eric Sandeen
2013-03-01 16:42 ` [PATCH] ext4: use percpu counter for extent cache count Eric Sandeen
2013-03-01 18:00 ` Theodore Ts'o
2013-03-01 18:02 ` Eric Sandeen
2013-03-02 15:26 ` Theodore Ts'o
2013-03-03 16:39 ` Zheng Liu
2013-03-04 16:11 ` Eric Sandeen
2013-03-02 19:54 ` [GIT PULL URGENT] ext4 regression fix for 3.9 Linus Torvalds
2013-03-02 23:15 ` Theodore Ts'o
2013-02-27 20:14 ` Theodore Ts'o
2013-02-27 20:58 ` [GIT PULL] ext4 updates " Dmitry Monakhov
2013-02-27 21:30 ` Theodore Ts'o
2013-03-01 15:41 ` Eric Sandeen
2013-02-28 13:18 ` Dave Chinner
2013-02-27 18:57 ` Dave Jones
2013-02-27 19:04 ` Theodore Ts'o
2013-02-27 19:11 ` Dave Jones
2013-02-27 19:19 ` Theodore Ts'o
2013-02-27 18:59 ` Zheng Liu
2013-02-27 19:06 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227190623.GH5530@pd.tnic \
--to=bp@alien8.de \
--cc=davej@redhat.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).