linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Dave Jones <davej@redhat.com>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"gnehzuil.liu" <gnehzuil.liu@gmail.com>,
	Zheng Liu <wenqing.lz@taobao.com>, Borislav Petkov <bp@alien8.de>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] ext4 updates for 3.9
Date: Wed, 27 Feb 2013 14:29:07 -0500	[thread overview]
Message-ID: <20130227192907.GB14253@thunk.org> (raw)
In-Reply-To: <20130227191923.GA1121@redhat.com>

On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote:
> 
> Looks like it's fixed here too.
> 
> How did this make it through -next without anyone hitting it ?
> 
> I can't remember how many years ago I last bought a disk < 1TB,
> and I can't be alone.  Or is everyone all about SSDs these days?

I use LVM, so I have a number of volues which are smaler than 512GB,
but very few which are actually larger than 1TB.  And none on my test
boxes.  I was running the bleeding edge ext4 code on my laptop as for
dogfooding purposes, but I have an 80GB mSATA SSD and a 500GB HDD on
my X230 laptop (it requires a thin laptop drive, and 7mm drives don't
come any bigger, alas).

> Is anyone running xfstests or similar on linux-next regularly ?

I run xfstests on the ext4 tree, and I ran it on ext4 plus Linus's tip
before I submitted a pull request.  The problem is that XFSTESTS is
S-L-O-W if you use large partitions, so typically I use a 5GB
partition sizes for my test runs.  Normally we're worried about race
condition bugs, not something as bone-headed as a bitmasking problem,
so it makes sense to use a smaller disk for most of your testing.
(Some folks do their xfstests run on SSD's or tmpfs image files, again
for speed reasons, and it's unlikely they would be big enough.)

So what we probably need to do is to have a separate set of tests
using a loopback mount, and perhaps an artificially created file
system which has a large percentage of the blocks in the middle of the
file system busied out, to make efficient testing of these sorts of
bugs more efficient.  As I said, I'm thinking about how's the best way
to improve our testing regime to catch such problems the next time around.

Cheers,

   	       	       	      	       	    - Ted

  parent reply	other threads:[~2013-02-27 19:29 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 20:39 [GIT PULL] ext4 updates for 3.9 Theodore Ts'o
2013-02-27 12:47 ` Markus Trippelsdorf
2013-02-27 15:34   ` Theodore Ts'o
2013-02-27 15:44     ` Markus Trippelsdorf
2013-02-27 17:01       ` Markus Trippelsdorf
2013-02-27 17:10         ` gnehzuil.liu
2013-02-27 17:22           ` Markus Trippelsdorf
2013-02-27 17:38             ` gnehzuil.liu
2013-02-27 17:45               ` Markus Trippelsdorf
2013-02-27 17:52                 ` Linus Torvalds
2013-02-27 18:49                   ` Theodore Ts'o
2013-02-27 18:56                     ` Markus Trippelsdorf
2013-02-27 19:19                       ` Dave Jones
2013-02-27 19:27                         ` Zheng Liu
2013-02-27 19:29                         ` Theodore Ts'o [this message]
2013-02-27 20:12                           ` [GIT PULL URGENT] ext4 regression fix " Linus Torvalds
2013-02-27 20:15                             ` Theodore Ts'o
2013-02-27 20:23                               ` Linus Torvalds
2013-02-27 20:41                                 ` Borislav Petkov
2013-03-01  3:30                             ` Dave Jones
2013-03-01  4:00                               ` Theodore Ts'o
2013-03-01  5:00                                 ` [PATCH] ext4: optimize ext4_es_shrink() Theodore Ts'o
2013-03-01 16:11                                   ` Dave Jones
2013-03-01 16:26                                     ` Theodore Ts'o
2013-03-01 16:40                                       ` Dave Jones
2013-03-01 16:40                                   ` Eric Sandeen
2013-03-01 16:42                                   ` [PATCH] ext4: use percpu counter for extent cache count Eric Sandeen
2013-03-01 18:00                                     ` Theodore Ts'o
2013-03-01 18:02                                       ` Eric Sandeen
2013-03-02 15:26                                         ` Theodore Ts'o
2013-03-03 16:39                                           ` Zheng Liu
2013-03-04 16:11                                           ` Eric Sandeen
2013-03-02 19:54                                 ` [GIT PULL URGENT] ext4 regression fix for 3.9 Linus Torvalds
2013-03-02 23:15                                   ` Theodore Ts'o
2013-02-27 20:14                           ` Theodore Ts'o
2013-02-27 20:58                           ` [GIT PULL] ext4 updates " Dmitry Monakhov
2013-02-27 21:30                             ` Theodore Ts'o
2013-03-01 15:41                             ` Eric Sandeen
2013-02-28 13:18                           ` Dave Chinner
2013-02-27 18:57                     ` Dave Jones
2013-02-27 19:04                       ` Theodore Ts'o
2013-02-27 19:11                         ` Dave Jones
2013-02-27 19:19                           ` Theodore Ts'o
2013-02-27 18:59                     ` Zheng Liu
2013-02-27 19:06                     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130227192907.GB14253@thunk.org \
    --to=tytso@mit.edu \
    --cc=bp@alien8.de \
    --cc=davej@redhat.com \
    --cc=gnehzuil.liu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=torvalds@linux-foundation.org \
    --cc=wenqing.lz@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).