From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [1/4] e2p: Fix 's' handling in parse_num_blocks2()
Date: Thu, 28 Feb 2013 20:13:14 -0500 [thread overview]
Message-ID: <20130301011314.GC18134@thunk.org> (raw)
In-Reply-To: <1361807708-15871-2-git-send-email-jack@suse.cz>
On Mon, Feb 25, 2013 at 05:55:05AM -0000, Jan Kara wrote:
> parse_num_blocks2() wrongly did:
> num << 1;
> when log_block_size < 0. That is obviously wrong as such statement has
> no effect (and the compiler properly warns about it). Callers expect
> returned value to be in bytes when log_block_size < 0 so fix the
> statement accordingly.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2013-03-01 1:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 15:55 [PATCH 0/4] Compilation fixes for e2fsprogs Jan Kara
2013-02-25 15:55 ` [PATCH 1/4] e2p: Fix 's' handling in parse_num_blocks2() Jan Kara
2013-03-01 1:13 ` Theodore Ts'o [this message]
2013-02-25 15:55 ` [PATCH 2/4] libext2fs: Fix return value in ext2fs_test_block_bitmap_range2() Jan Kara
2013-03-01 1:06 ` [2/4] " Theodore Ts'o
2013-02-25 15:55 ` [PATCH 3/4] libext2fs: Provide prototype for ext2fs_symlink() Jan Kara
2013-03-01 1:13 ` [3/4] " Theodore Ts'o
2013-02-25 15:55 ` [PATCH 4/4] resize: bigalloc_check() should have return type void Jan Kara
2013-03-01 1:07 ` [4/4] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301011314.GC18134@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).