* [PATCH] ext4: fix a warning from sparse check for ext4_dir_llseek
@ 2013-02-19 9:08 Zheng Liu
2013-03-02 22:25 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Liu @ 2013-02-19 9:08 UTC (permalink / raw)
To: linux-ext4; +Cc: Zheng Liu
From: Zheng Liu <wenqing.lz@taobao.com>
ext4_dir_llseek is only used as a callback function, and no one calls
it directly. So make it as a static function in order to remove a
warning message from sparse check.
Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
fs/ext4/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index 80a28b2..39460ac 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -333,7 +333,7 @@ static inline loff_t ext4_get_htree_eof(struct file *filp)
*
* For non-htree, ext4_llseek already chooses the proper max offset.
*/
-loff_t ext4_dir_llseek(struct file *file, loff_t offset, int whence)
+static loff_t ext4_dir_llseek(struct file *file, loff_t offset, int whence)
{
struct inode *inode = file->f_mapping->host;
int dx_dir = is_dx_dir(inode);
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: fix a warning from sparse check for ext4_dir_llseek
2013-02-19 9:08 [PATCH] ext4: fix a warning from sparse check for ext4_dir_llseek Zheng Liu
@ 2013-03-02 22:25 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-03-02 22:25 UTC (permalink / raw)
To: Zheng Liu; +Cc: linux-ext4, Zheng Liu
On Tue, Feb 19, 2013 at 05:08:46PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> ext4_dir_llseek is only used as a callback function, and no one calls
> it directly. So make it as a static function in order to remove a
> warning message from sparse check.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-02 22:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 9:08 [PATCH] ext4: fix a warning from sparse check for ext4_dir_llseek Zheng Liu
2013-03-02 22:25 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).