From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH 1/2] ext4: Don't allow quota mount options when quota feature enabled Date: Sat, 2 Mar 2013 18:04:06 -0500 Message-ID: <20130302230406.GF22941@thunk.org> References: <1361835369-19850-1-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org To: Jan Kara Return-path: Received: from li9-11.members.linode.com ([67.18.176.11]:50966 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970Ab3CBXEK (ORCPT ); Sat, 2 Mar 2013 18:04:10 -0500 Content-Disposition: inline In-Reply-To: <1361835369-19850-1-git-send-email-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, Feb 26, 2013 at 12:36:08AM +0100, Jan Kara wrote: > So far we silently ignored when quota mount options were set while quota > feature was enabled. But this can create confusion in userspace when > mount options are set but silently ignored and also creates opportunities > for bugs when we don't properly test all quota types. Actually > ext4_mark_dquot_dirty() forgets to test for quota feature so it was > dependent on journaled quota options being set. OTOH ext4_orphan_cleanup() > tries to enable journaled quota when quota options are specified which is > wrong when quota feature is enabled. > > Signed-off-by: Jan Kara Thanks, applied. - Ted