From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: don't assume that falloc_punch implies falloc in test 255
Date: Thu, 7 Mar 2013 00:52:26 +0800 [thread overview]
Message-ID: <20130306165226.GA3454@gmail.com> (raw)
In-Reply-To: <51376A61.6060807@redhat.com>
On Wed, Mar 06, 2013 at 10:10:09AM -0600, Eric Sandeen wrote:
> On 3/5/13 11:59 AM, Theodore Ts'o wrote:
> > As of Linux 3.9-rc1, ext4 will support the punch operation on file
> > systems using indirect blocks, but it can not support the fallocate
> > operation (since there is no way to mark a block as uninitialized
> > using indirect block scheme). This caused test 255 to fail, since it
> > only used _require_xfS_io_falloc_punch assuming that all file systems
> > which supported punch can also support fallocate. Fix this.
>
> Seems fine to avoid the incorrect failure, so as far as that goes:
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> But we probably can & should still test punch in this situation,
> so we need a new test to exercise that I guess.
Hi Eric,
I have sent a patch set to add a test case for punching hole. You can
find it in this link [1]. Sorry I don't finish the second version
according to Mark's comment.
1. http://www.spinics.net/lists/xfs/msg16234.html
Regards,
- Zheng
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-03-06 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 17:59 [PATCH] xfstests: don't assume that falloc_punch implies falloc in test 255 Theodore Ts'o
2013-03-05 18:51 ` Rich Johnston
2013-03-05 19:07 ` Rich Johnston
2013-03-06 16:10 ` Eric Sandeen
2013-03-06 16:52 ` Zheng Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306165226.GA3454@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).