From: Theodore Ts'o <tytso@mit.edu>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "Lukáš Czerner" <lczerner@redhat.com>,
"Chris Ball" <cjb@laptop.org>,
linux-ext4@vger.kernel.org, "Stephen Warren" <swarren@nvidia.com>
Subject: Re: [PATCH] mke2fs: restore verbose message for BLKDISCARD
Date: Fri, 8 Mar 2013 14:00:19 -0500 [thread overview]
Message-ID: <20130308190019.GB12008@thunk.org> (raw)
In-Reply-To: <513A1D56.1010402@wwwdotorg.org>
I hate to suggest this, but there's so many crappy devices out there
that I'm wondering if we need to figure out some way of maintaining a
black list of devices that don't handle discard properly. For
example, the Sandisk U100 advertises a max discard granularity of 512
bytes, but I've been advised that if you don't use a discard
granularity of 256k, aligned on 256k, you'll be very, very, sorry.
It sounds like Stephen's device is probably an example of Yet Another
Busted Trim implementation. The problem is that manufacturers will be
releasing more broken products faster than we can update a blacklist
in the kernel. So any blacklist would have to be maintained online on
the web, and dynamically updated by distro installers. :-(
- Ted
next prev parent reply other threads:[~2013-03-08 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 20:25 [PATCH] mke2fs: restore verbose message for BLKDISCARD Stephen Warren
2013-03-06 7:13 ` Lukáš Czerner
2013-03-07 19:47 ` Stephen Warren
2013-03-08 7:23 ` Lukáš Czerner
2013-03-08 17:18 ` Stephen Warren
2013-03-08 19:00 ` Theodore Ts'o [this message]
2013-03-08 19:06 ` Theodore Ts'o
2013-03-08 19:08 ` Chris Ball
2013-03-08 20:03 ` Stephen Warren
2013-03-08 20:12 ` Chris Ball
2013-03-11 14:08 ` Eric Sandeen
2013-03-11 14:18 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308190019.GB12008@thunk.org \
--to=tytso@mit.edu \
--cc=cjb@laptop.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).