linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: Mixup with name_len & file_type in e2fsprogs
Date: Mon, 11 Mar 2013 15:18:56 +0100	[thread overview]
Message-ID: <20130311141856.GJ29799@quack.suse.cz> (raw)
In-Reply-To: <20130308004620.GB29720@thunk.org>

On Thu 07-03-13 19:46:20, Ted Tso wrote:
> By the way, why was the application trying to access the directory
> entries directly, as opposed to using some of the higher level
> functions in libext2fs?  What was it trying to do?
  It was btrfs-convert (I could have told that in my original email as well
but it didn't seem important) - i.e. inplace convertor from ext4 to btrfs.
So it really needed to get the file type from the directory block to fill
in appropriate btrfs structures.

> Is there some new higher-level functionality we should be providing?
> Or was this just an application that didn't know about some better
> interface that it could have used?  Is this an open source
> application?  Can you send me a pointer to it?
  btrfs-convert is part of btrfsprogs so feel free to have a look. I don't
think we can actually provide some high level functionality to serve its
needs. It really just needs to do readdir(2) on fs image which is what is
already implemented in libext2fs.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

      reply	other threads:[~2013-03-11 14:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 12:18 Mixup with name_len & file_type in e2fsprogs Jan Kara
2013-03-05 18:29 ` Theodore Ts'o
2013-03-05 18:41   ` Jan Kara
2013-03-07 18:24     ` Jan Kara
2013-03-07 23:00       ` Andreas Dilger
2013-03-08  0:44       ` Theodore Ts'o
2013-03-08  0:46       ` Theodore Ts'o
2013-03-11 14:18         ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130311141856.GJ29799@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).