From: Jan Kara <jack@suse.cz>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: Ted Tso <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Possible bug with extent status tree
Date: Mon, 11 Mar 2013 21:38:34 +0100 [thread overview]
Message-ID: <20130311203834.GA22229@quack.suse.cz> (raw)
Hello,
while looking into the ext4 code I spotted one thing which I think is a
bug introduced by extent status tree code. The problem is that
ext4_map_blocks() checks extent status tree and if the extent is found, it
doesn't call into ext4_ext_map_blocks(). However ext4_ext_direct_IO() expects
that if the extent DIO is done to is unwritten, EXT4_IO_END_UNWRITTEN flag
gets set in the io_end (or inode) flags and that happens only in
ext4_ext_map_blocks().
The easiest fix seems to be to move setting of flags from
ext4_ext_map_blocks() up into ext4_map_blocks() (or maybe even
_ext4_get_block()). What do you think?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next reply other threads:[~2013-03-11 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 20:38 Jan Kara [this message]
2013-03-12 3:53 ` Possible bug with extent status tree Zheng Liu
2013-03-12 9:32 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130311203834.GA22229@quack.suse.cz \
--to=jack@suse.cz \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).