From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com, linux-ext4@vger.kernel.org,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] xfstests 299-305: remove fio config files after finished test
Date: Wed, 20 Mar 2013 13:37:44 +0800 [thread overview]
Message-ID: <20130320053744.GA4017@gmail.com> (raw)
In-Reply-To: <51489024.20301@sandeen.net>
On Tue, Mar 19, 2013 at 11:19:48AM -0500, Eric Sandeen wrote:
> On 3/19/13 4:30 AM, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@taobao.com>
> >
> > After finished test, temporarily fio config file should be removed.
>
> Looks fine, except that in test 300 you don't do rm -f; in every
> other test -f is used. Was that intentional?
Thanks for pointing it out. It's a typo. I will submit a newer patch
to fix it.
>
> Also, while looking at this, in 305 cleanup uses "poweron_scratch_dev"
> - is that defined anywhere? I can't find it.
Yeah, I also cannot find it. I am not sure why it is called here. I
will take a look at it and make sure that we can remove it.
Regards,
- Zheng
next prev parent reply other threads:[~2013-03-20 5:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 9:30 [PATCH] xfstests 299-305: remove fio config files after finished test Zheng Liu
2013-03-19 16:19 ` Eric Sandeen
2013-03-20 5:37 ` Zheng Liu [this message]
2013-03-21 1:09 ` Dave Chinner
2013-03-21 2:07 ` Eric Sandeen
2013-03-21 2:47 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320053744.GA4017@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).