From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-ext4@vger.kernel.org, Eric Sandeen <sandeen@sandeen.net>,
Zheng Liu <wenqing.lz@taobao.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests 299-305: remove fio config files after finished test
Date: Wed, 27 Mar 2013 19:55:02 +0800 [thread overview]
Message-ID: <20130327115502.GA23236@gmail.com> (raw)
In-Reply-To: <20130327020532.GP6369@dastard>
On Wed, Mar 27, 2013 at 01:05:33PM +1100, Dave Chinner wrote:
> On Sun, Mar 24, 2013 at 08:14:26PM +0800, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@taobao.com>
> >
> > After finished test, temporarily fio config file should be removed.
> > Meanwhile in #305 poweron_scratch_dev is removed because no one uses
> > it.
> >
> > Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> > Cc: Eric Sandeen <sandeen@sandeen.net>
> > Cc: Dave Chinner <david@fromorbit.com>
> > ---
> > 299 | 9 +++++----
> > 300 | 9 +++++----
> > 301 | 9 +++++----
> > 302 | 9 +++++----
> > 303 | 9 +++++----
> > 304 | 9 +++++----
> > 305 | 11 ++++++-----
> > 7 files changed, 36 insertions(+), 29 deletions(-)
> > mode change 100644 => 100755 299
> > mode change 100644 => 100755 300
> > mode change 100644 => 100755 301
> > mode change 100644 => 100755 302
> > mode change 100644 => 100755 303
> > mode change 100644 => 100755 304
> > mode change 100644 => 100755 305
>
> Mode changes should be in a separate patch. And if you are going to
> do this, please change all the tests that need this to be done in
> one sweep.
Hi Dave,
Thanks for pointing it out. I will send a latest version. Meanwhile I
notice that now test cases have been moved into tests dir and splitted
into different parts. So I will rebase my patch aginst latest xfstests.
Thanks,
- Zheng
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-03-27 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 12:14 [PATCH v2] xfstests 299-305: remove fio config files after finished test Zheng Liu
2013-03-27 2:05 ` Dave Chinner
2013-03-27 11:55 ` Zheng Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327115502.GA23236@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).