From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] ext4: Make ext4_block_in_group() much more efficient
Date: Wed, 27 Mar 2013 09:34:44 -0400 [thread overview]
Message-ID: <20130327133444.GH5861@thunk.org> (raw)
In-Reply-To: <1364382245-32510-1-git-send-email-lczerner@redhat.com>
On Wed, Mar 27, 2013 at 12:04:04PM +0100, Lukas Czerner wrote:
> #define EXT4_MOUNT2_EXPLICIT_DELALLOC 0x00000001 /* User explicitly
> specified delalloc */
> +#define EXT4_MOUNT_STD_GROUP_SIZE 0x00000002 /* We have standard group
> + size of blocksize * 8
> + blocks */
This should be EXT4_MOUNT2_STD_GROUP_SIZE, and then all calls to
set_opt, test_opt, etc. should be set_opt2, test_opt2, etc. As it
turns out bit 0x0002 isn't used for flags in s_mount_opt family, so
the other fix would be to move this definition to before
EXT4_MOUNT_GRPID in ext4.
However, the EXT4_MOUNT_* options should be reserved for options that
are set via mount options, since we have support for setting bits in
s_mount_opt via a table-driven approach (see how the mount_opt field
in the struct mount_opts in fs/ext4/super.c is used). So for things
that are set automatically, such as in this case, we should use a bit
assignment for s_mount_opt2.
Cheers,
- Ted
prev parent reply other threads:[~2013-03-27 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 11:04 [PATCH 1/2 v2] ext4: Make ext4_block_in_group() much more efficient Lukas Czerner
2013-03-27 11:04 ` [PATCH 2/2 v2] ext4: introduce ext4_get_group_number() Lukas Czerner
2013-03-27 13:34 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327133444.GH5861@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).