From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] ext4: take i_mutex in ext4_symlink to eliminate a warning from ext4_truncate
Date: Wed, 27 Mar 2013 22:02:50 +0800 [thread overview]
Message-ID: <20130327140250.GA4316@gmail.com> (raw)
In-Reply-To: <20130327134110.GI5861@thunk.org>
On Wed, Mar 27, 2013 at 09:41:10AM -0400, Theodore Ts'o wrote:
> On Wed, Mar 27, 2013 at 09:19:07PM +0800, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@taobao.com>
> >
> > After applied this commit (8e4061cb), we will get a warning from
> > ext4_truncate when i_mutex isn't taken. Here the assumption is that
> > i_mutex should be taken when we do a truncation. In ext4_symlink we
> > could need to call ext4_truncate to trim some blocks beyond i_size, but
> > the i_mutex isn't taken.
>
> Hmm, and this is why I added the warning. Even after looking your
> patch, I'm having trouble finding the codepath that results in
> ext4_truncate() getting called from __page_symlink(). Can you send
> the stack trace from the WARN_ON, just so I can see what I missed?
Here it is.
kernel: ------------[ cut here ]------------
kernel: WARNING: at fs/ext4/inode.c:3803 ext4_truncate+0x36/0x2d7 [ext4]()
kernel: Hardware name: OptiPlex 780
kernel: Modules linked in: ext4(O) jbd2 crc16 cpufreq_ondemand ipv6
dm_mirror dm_region_hash dm_log dm_mod parport_pc parport dcdbas
acpi_cpufreq mperf serio_raw button pcspkr i2c_i801 sg ehci_pci
ehci_hcd e1000e ptp pps_core ext3 jbd sd_mod ahci libahci libata
scsi_mod uhci_hcd radeon ttm drm_kms_helper drm hwmon i2c_algo_bit i2
c_core [last unloaded: crc16]
kernel: Pid: 4152, comm: fsstress Tainted: G W O 3.9.0-rc4+ #6
kernel: Call Trace:
kernel: [<ffffffff82031e14>] warn_slowpath_common+0x85/0x9f
kernel: [<ffffffff82031e48>] warn_slowpath_null+0x1a/0x1c
kernel: [<ffffffffa044b789>] ext4_truncate+0x36/0x2d7 [ext4]
kernel: [<ffffffffa044c9a5>] ext4_write_begin+0x35f/0x3b9 [ext4]
kernel: [<ffffffff820af514>] pagecache_write_begin+0x1c/0x1e
kernel: [<ffffffff820f5f80>] __page_symlink+0x6d/0x10f
kernel: [<ffffffffa0450806>] ? ext4_orphan_add+0x1ea/0x219 [ext4]
kernel: [<ffffffffa0451a7f>] ext4_symlink+0x1ca/0x33e [ext4]
kernel: [<ffffffff820f8c41>] vfs_symlink+0x7c/0xd6
kernel: [<ffffffff820fb634>] sys_symlinkat+0x68/0xb9
kernel: [<ffffffff820fb69b>] sys_symlink+0x16/0x18
kernel: [<ffffffff8238fac2>] system_call_fastpath+0x16/0x1b
kernel: ---[ end trace 05d179cc296c4f3a ]---
Regards,
- Zheng
next prev parent reply other threads:[~2013-03-27 13:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 13:19 [PATCH] ext4: take i_mutex in ext4_symlink to eliminate a warning from ext4_truncate Zheng Liu
2013-03-27 13:41 ` Theodore Ts'o
2013-03-27 14:02 ` Zheng Liu [this message]
2013-03-27 13:51 ` Theodore Ts'o
2013-03-27 15:07 ` Zheng Liu
2013-03-27 15:19 ` Zheng Liu
2013-03-27 15:12 ` Theodore Ts'o
2013-03-27 15:35 ` Zheng Liu
2013-03-28 14:06 ` Theodore Ts'o
2013-04-01 15:23 ` [PATCH] fs: take i_mutex in __page_symlink() Theodore Ts'o
2013-04-01 16:35 ` Al Viro
2013-04-01 17:38 ` Theodore Ts'o
2013-04-02 8:19 ` Dmitry Monakhov
2013-03-27 14:04 ` [PATCH] ext4: take i_mutex in ext4_symlink to eliminate a warning from ext4_truncate Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327140250.GA4316@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).