* Re: [qrxd43@motorola.com: [PATCH V2] ext4: speed-up releasing blocks on commit] [not found] ` <94F448E5-429B-4740-BF87-CE82F477DE93@gmail.com> @ 2013-03-13 10:38 ` Andrey Sidorov 2013-03-13 11:37 ` Theodore Ts'o 2013-03-27 14:57 ` Theodore Ts'o 0 siblings, 2 replies; 4+ messages in thread From: Andrey Sidorov @ 2013-03-13 10:38 UTC (permalink / raw) To: Alex Tomas; +Cc: Andreas Dilger, linux-ext4 Hi Alex, Thanks for review! I'll post rebased patch with comments and some ascii art this weekend. > the patch looks fine, the only suggestion is to move the following logic > into mb_buddy_mark_free(): > > + if (first & 1) { > + first += !left_is_free; > + e4b->bd_info->bb_counters[0] += left_is_free ? -1 : 1; > + } > + if (!(last & 1)) { > + last -= !right_is_free; > + e4b->bd_info->bb_counters[0] += right_is_free ? -1 : 1; > + } I didn't do that since buddy[0] is a special case since it is in fact bd_bitmap itself. Moving that into mb_buddy_mark_free will make code look worse because of this special handling. I think unrolling first iteration that handles bd_bitmap looks much better. Regards, Andrey. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [qrxd43@motorola.com: [PATCH V2] ext4: speed-up releasing blocks on commit] 2013-03-13 10:38 ` [qrxd43@motorola.com: [PATCH V2] ext4: speed-up releasing blocks on commit] Andrey Sidorov @ 2013-03-13 11:37 ` Theodore Ts'o 2013-03-27 14:57 ` Theodore Ts'o 1 sibling, 0 replies; 4+ messages in thread From: Theodore Ts'o @ 2013-03-13 11:37 UTC (permalink / raw) To: Andrey Sidorov; +Cc: Alex Tomas, Andreas Dilger, linux-ext4 On Wed, Mar 13, 2013 at 02:38:55PM +0400, Andrey Sidorov wrote: > Hi Alex, > > Thanks for review! I'll post rebased patch with comments and some > ascii art this weekend. Was the review cc'ed to the linux-ext4 list? I didn't see it. Could someone forward it to me? Thanks!! - Ted ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [qrxd43@motorola.com: [PATCH V2] ext4: speed-up releasing blocks on commit] 2013-03-13 10:38 ` [qrxd43@motorola.com: [PATCH V2] ext4: speed-up releasing blocks on commit] Andrey Sidorov 2013-03-13 11:37 ` Theodore Ts'o @ 2013-03-27 14:57 ` Theodore Ts'o 2013-03-28 19:30 ` Andrey Sidorov 1 sibling, 1 reply; 4+ messages in thread From: Theodore Ts'o @ 2013-03-27 14:57 UTC (permalink / raw) To: Andrey Sidorov; +Cc: Alex Tomas, Andreas Dilger, linux-ext4 On Wed, Mar 13, 2013 at 02:38:55PM +0400, Andrey Sidorov wrote: > > Thanks for review! I'll post rebased patch with comments and some > ascii art this weekend. Hi Andrey, have you had a chance to post a rebased patch for your proposed change? If not, it would be great if you could look at doing this against either 3.9-rc4 or the ext4 dev branch, since we're not actively looking at patches for the next merge window. Thanks!! - Ted ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [qrxd43@motorola.com: [PATCH V2] ext4: speed-up releasing blocks on commit] 2013-03-27 14:57 ` Theodore Ts'o @ 2013-03-28 19:30 ` Andrey Sidorov 0 siblings, 0 replies; 4+ messages in thread From: Andrey Sidorov @ 2013-03-28 19:30 UTC (permalink / raw) To: Theodore Ts'o; +Cc: Alex Tomas, Andreas Dilger, linux-ext4 Hi Ted, I've just posted version rebased to yesterday's ext4 dev. Regards, Andrey. On Wed, Mar 27, 2013 at 6:57 PM, Theodore Ts'o <tytso@mit.edu> wrote: > On Wed, Mar 13, 2013 at 02:38:55PM +0400, Andrey Sidorov wrote: >> >> Thanks for review! I'll post rebased patch with comments and some >> ascii art this weekend. > > Hi Andrey, have you had a chance to post a rebased patch for your > proposed change? If not, it would be great if you could look at doing > this against either 3.9-rc4 or the ext4 dev branch, since we're not > actively looking at patches for the next merge window. > > Thanks!! > > - Ted ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-28 19:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130203031122.GC1359@thunk.org>
[not found] ` <88575CD0-1CF4-4C12-83ED-845C87FFFDA4@dilger.ca>
[not found] ` <94F448E5-429B-4740-BF87-CE82F477DE93@gmail.com>
2013-03-13 10:38 ` [qrxd43@motorola.com: [PATCH V2] ext4: speed-up releasing blocks on commit] Andrey Sidorov
2013-03-13 11:37 ` Theodore Ts'o
2013-03-27 14:57 ` Theodore Ts'o
2013-03-28 19:30 ` Andrey Sidorov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).