From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Zheng Liu <gnehzuil.liu@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix data corruption with direct IO read in dioread_nolock mode
Date: Thu, 11 Apr 2013 23:18:37 -0400 [thread overview]
Message-ID: <20130412031837.GA4865@thunk.org> (raw)
In-Reply-To: <20130411210756.GC9379@quack.suse.cz>
On Thu, Apr 11, 2013 at 11:07:56PM +0200, Jan Kara wrote:
> Doh, you are right. I didn't notice that. Thanks for correcting me. I was
> seeing a failure in xfstest 091 (fsx using direct IO) with dioread_nolock
> and I thought the missing flush was the culprit (as fsx saw non-zeros in
> the tail of the page that was truncated). After adding the flush I didn't
> see it anymore. But now I'm not able to trigger the failure again
> regardless whether the patch is applied or not. So Ted, please drop the
> patch and I'll watch out if I ever see the failure again.
Dropped.
- Ted
prev parent reply other threads:[~2013-04-12 3:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 16:27 [PATCH] ext4: Fix data corruption with direct IO read in dioread_nolock mode Jan Kara
2013-04-10 21:08 ` Jan Kara
2013-04-11 0:47 ` Theodore Ts'o
2013-04-11 13:20 ` Zheng Liu
2013-04-11 21:07 ` Jan Kara
2013-04-12 3:18 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130412031837.GA4865@thunk.org \
--to=tytso@mit.edu \
--cc=gnehzuil.liu@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).