From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH -v3] ext4: move quota initialization out of inode allocation transaction
Date: Fri, 19 Apr 2013 16:30:28 +0200 [thread overview]
Message-ID: <20130419143028.GA26647@quack.suse.cz> (raw)
In-Reply-To: <1366327444-6123-1-git-send-email-tytso@mit.edu>
Still not quite...
On Thu 18-04-13 19:24:04, Ted Tso wrote:
> @@ -951,24 +971,17 @@ got:
>
> ext4_debug("allocating inode %lu\n", inode->i_ino);
> trace_ext4_allocate_inode(inode, dir, mode);
> - goto really_out;
> -fail:
> - ext4_std_error(sb, err);
> -out:
> - iput(inode);
> - ret = ERR_PTR(err);
> -really_out:
> brelse(inode_bitmap_bh);
> return ret;
>
> fail_free_drop:
> dquot_free_inode(inode);
> -
> fail_drop:
> - dquot_drop(inode);
> - inode->i_flags |= S_NOQUOTA;
> clear_nlink(inode);
> unlock_new_inode(inode);
> +out:
> + inode->i_flags |= S_NOQUOTA;
> + dquot_drop(inode);
The above two lines have to be swapped to preserve original ordering
which is actually important. Thanks.
Honza
> iput(inode);
> brelse(inode_bitmap_bh);
> return ERR_PTR(err);
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-04-19 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 8:34 [PATCH 1/2] ext4: Improve credit estimate for EXT4_SINGLEDATA_TRANS_BLOCKS Jan Kara
2013-04-09 8:34 ` [PATCH 2/2] ext4: Move quota initialization out of inode allocation transaction Jan Kara
2013-04-09 16:42 ` Theodore Ts'o
2013-04-18 19:07 ` Theodore Ts'o
2013-04-18 21:46 ` Jan Kara
2013-04-18 23:24 ` [PATCH -v3] ext4: move " Theodore Ts'o
2013-04-19 14:30 ` Jan Kara [this message]
2013-04-19 16:24 ` Theodore Ts'o
2013-04-19 19:21 ` Jan Kara
2013-04-09 16:42 ` [PATCH 1/2] ext4: Improve credit estimate for EXT4_SINGLEDATA_TRANS_BLOCKS Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419143028.GA26647@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).