* ext4: mext_insert_extents should update extent block checksum
@ 2013-04-19 5:50 Darrick J. Wong
2013-04-19 18:20 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2013-04-19 5:50 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Zheng Liu, Ext4 Developers List
When we alter any part of the extent tree that is not part of the inode during
on online defrag, we must update the extent header's checksum before dirtying
the block.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/ext4/ext4_extents.h | 5 +++++
fs/ext4/extents.c | 7 ++-----
fs/ext4/move_extent.c | 13 +------------
3 files changed, 8 insertions(+), 17 deletions(-)
diff --git a/fs/ext4/ext4_extents.h b/fs/ext4/ext4_extents.h
index 8643ff5..51bc821 100644
--- a/fs/ext4/ext4_extents.h
+++ b/fs/ext4/ext4_extents.h
@@ -270,5 +270,10 @@ static inline void ext4_idx_store_pblock(struct ext4_extent_idx *ix,
0xffff);
}
+#define ext4_ext_dirty(handle, inode, path) \
+ __ext4_ext_dirty(__func__, __LINE__, (handle), (inode), (path))
+int __ext4_ext_dirty(const char *where, unsigned int line, handle_t *handle,
+ struct inode *inode, struct ext4_ext_path *path);
+
#endif /* _EXT4_EXTENTS */
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 9c6d06d..cd43b4c 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -157,11 +157,8 @@ static int ext4_ext_get_access(handle_t *handle, struct inode *inode,
* - ENOMEM
* - EIO
*/
-#define ext4_ext_dirty(handle, inode, path) \
- __ext4_ext_dirty(__func__, __LINE__, (handle), (inode), (path))
-static int __ext4_ext_dirty(const char *where, unsigned int line,
- handle_t *handle, struct inode *inode,
- struct ext4_ext_path *path)
+int __ext4_ext_dirty(const char *where, unsigned int line, handle_t *handle,
+ struct inode *inode, struct ext4_ext_path *path)
{
int err;
if (path->p_bh) {
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 33e1c08..9a20c91 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -407,18 +407,7 @@ mext_insert_extents(handle_t *handle, struct inode *orig_inode,
mext_insert_inside_block(o_start, o_end, start_ext, new_ext,
end_ext, eh, range_to_move);
- if (depth) {
- ret = ext4_handle_dirty_metadata(handle, orig_inode,
- orig_path->p_bh);
- if (ret)
- return ret;
- } else {
- ret = ext4_mark_inode_dirty(handle, orig_inode);
- if (ret < 0)
- return ret;
- }
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ext4: mext_insert_extents should update extent block checksum
2013-04-19 5:50 ext4: mext_insert_extents should update extent block checksum Darrick J. Wong
@ 2013-04-19 18:20 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-04-19 18:20 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Zheng Liu, Ext4 Developers List
On Thu, Apr 18, 2013 at 10:50:12PM -0700, Darrick J. Wong wrote:
> When we alter any part of the extent tree that is not part of the inode during
> on online defrag, we must update the extent header's checksum before dirtying
> the block.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-19 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-19 5:50 ext4: mext_insert_extents should update extent block checksum Darrick J. Wong
2013-04-19 18:20 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).