From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
David Shaw <dshaw@jabberwocky.com>,
Harald Reindl <h.reindl@thelounge.net>
Subject: Re: [PATCH] e2fsprogs: allow 0-length xattr values in e2fsck
Date: Thu, 25 Apr 2013 00:20:01 -0400 [thread overview]
Message-ID: <20130425042001.GA4685@thunk.org> (raw)
In-Reply-To: <5161BE0A.5070003@redhat.com>
On Sun, Apr 07, 2013 at 01:42:18PM -0500, Eric Sandeen wrote:
> e2fsck thinks that this:
>
> # touch mnt/testfile1
> # setfattr -n "user.test" mnt/testfile1
>
> results in a filesystem with corruption:
>
> Pass 1: Checking inodes, blocks, and sizes
> Extended attribute in inode 12 has a value size (0) which is invalid
> Clear? yes
>
> but as far as I can tell, there is absolutely nothing wrong with
> a 0-length value on an extended attribute. Just remove the check.
>
> Reported-by: David Shaw <dshaw@jabberwocky.com>
> Reported-by: Harald Reindl <h.reindl@thelounge.net>
> Addresses-Red-Hat-Bugzilla: #557959
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied.
It turns out that 0-length values applied for xattrs stored in
external xattr blocks. 0-length xattrs were only only getting
prohibited for in-inode xattrs.
- Ted
prev parent reply other threads:[~2013-04-25 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 18:42 [PATCH] e2fsprogs: allow 0-length xattr values in e2fsck Eric Sandeen
2013-04-12 17:02 ` Eric Sandeen
2013-04-25 4:20 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425042001.GA4685@thunk.org \
--to=tytso@mit.edu \
--cc=dshaw@jabberwocky.com \
--cc=h.reindl@thelounge.net \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).